Liquid Ajax Cart x PJAX about liquid-ajax-cart HOT 16 CLOSED

No I didn't. You're good to go.🙌🏽

from liquid-ajax-cart.

@haroldao
Aha. So it means that your PJAX root element is not body but under it.
What if you subscribe to the page change event (i think it is possible) and remove the js-cart-open class on every page change. I think it should be the only problem. All the other LAC classes depend on the cart state and shouldn't be changed after page change.

from liquid-ajax-cart.

I use "Operator" https://github.com/estrattonbailey/operator with Shopify Theme Lab https://github.com/uicrooks/shopify-theme-lab

from liquid-ajax-cart.

I don't use Slater but you can see Operator here (https://github.com/the-couch/slater/blob/master/packages/theme/src/scripts/router.js)

from liquid-ajax-cart.

Here's what I've got in my console

from liquid-ajax-cart.

Hey @haroldao . Can you guide me how I can replicate this issue on my local computer?
So as I understand I need to install the "shopify-theme-lab" theme, then install the "operator". Then I need to see the code how you use the operator and Liquid Ajax Cart.
Btw does this issue disappear if you remove the "operator" ?

from liquid-ajax-cart.

😮😮😮... yes I still have the error message @EvgeniyMukhamedjanov when I remove operator
Here's the file where I imported L.A.C

from liquid-ajax-cart.

from liquid-ajax-cart.

@haroldao
Yeah, for sure it is not related to the Operator or any other package. It should be a problem with Webpack/Module system. I'll install the shopify-theme-lab tomorrow and try to import LAC. For now you can include LAC as you did it on the previous project — using <script type="module">. After I find out what is the issue -- I let you know and you install LAC using npm again.
Can you also tell me if you did any changes in the "package.json" or any config files and if they are different from the current shopify-theme-lab repository?

from liquid-ajax-cart.

Side note : It's almost working (with your "manual" solution).... but when we change the page it's not working anymore since we have to "reload" the JS each time a page transition happens

from liquid-ajax-cart.

Hey @haroldao , I guess I found what was the issue. Can you please try if the updated version works for you:
https://github.com/EvgeniyMukhamedjanov/liquid-ajax-cart/blob/dev/docs/releases/liquid-ajax-cart-v1.10.1.js

Just download the file and put it next to the main.js and include it like this:

import './liquid-ajax-cart-v1.10.1.js';

and check if it works for you.

Please pay attention that Liquid Ajax Cart applies CSS classes to the body tag. It means if your PJAX root element is the body tag then after page change the classes will be missed. If it is the case then I can add an option to LAC to apply classes to the html tag.

Once all is good I'll upload the v1.10.1 to npm as well.

from liquid-ajax-cart.

yeah it's working well ✅.

Okay that's fine. I'll get rid of PJAX for this project then.

from liquid-ajax-cart.

@haroldao
Why do you want to get rid of PJAX? LAC should work well with PJAX because LAC listens only document events thus you can change DOM as you want.
Does LAC work after PJAX page change?

from liquid-ajax-cart.

no it's not working well.

here's a quick example : When I click a button (to open the cart drawer) and I change the page, the class js-cart-open is still set on the body

from liquid-ajax-cart.

Hey @haroldao
I've just updated the npm version, so you can remove the local file and install it from npm.
Let me know if it works for you and I'll close the issue then :-)

from liquid-ajax-cart.

thank you man✨🙌🏽

from liquid-ajax-cart.