Git Product home page Git Product logo

Comments (2)

HolgerDoerner avatar HolgerDoerner commented on May 20, 2024

Hello @codeliner , I didn't realized that You had already assigned Yourself to this Issue when I created the PR 😞
But if You don't mind, I would really appreciate it if You would accept my PR. And if You would also label this Issue and/or the PR for Hacktoberfest, I would be very happy 😄

from php-event-store.

codeliner avatar codeliner commented on May 20, 2024

Hey @HolgerDoerner, thank you for your contribution. Yeah, I assigned the issue to myself as a reminder. Adding the methods to the interface is only half of the story ;) The real work needs to be done in the prooph/event-store bridge here: https://github.com/event-engine/prooph-v7-event-store/blob/master/src/ProophEventStore.php#L26

I can only merge your PR if the methods are implemented in the bridge ☝️ and some tests are added there, too.
prooph/event-store provides the functionality, so the bridge just has to translate. Should be straight forward. You can work on it, if you want. If you have questions, ask anytime. I don't have time at the moment to work on it myself.

from php-event-store.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.