Comments (3)
My guess is that Vite does a find and replace on
__VITE_PRELOAD__
which breaks when the slash newline is introduced, but I can't say for sure.
That's my guess as well given your description, and given that I think I've read of Vite doing other things like that in the past. But that's not a problem with esbuild. If you need to post-process esbuild's output with such a tool, then perhaps you don't want to use the line limit setting? Either that or the other tool would have to be fixed.
from esbuild.
I was wondering if there wasn't already a way to preserve strings through either comment or some option in existing minifiers like terser, but I can't seem to find any. This is probably a very rare edge-case that I stumbled upon.
I'll make a cross-post to Vite to see if they can cover this edge-case.
from esbuild.
I'm closing this issue because this is not a problem with esbuild. The strings that esbuild is generating are still valid JavaScript strings. It makes sense that tools using regexp-based post-processing don't automatically work with JavaScript like that, but in that case you should be able to disable the line limit setting until the other tools are fixed (or if they decide that it's not a problem worth fixing).
from esbuild.
Related Issues (20)
- Dynamic import not resolved during build HOT 1
- Static class fields canβt be tree-shaken away on subsequent compilation
- Cloudflare breaks the minimized code for Float's HOT 3
- compilerOptions.paths not resolved when tsconfig extends from another package HOT 1
- ES decorators bug with inheritance and --bundle
- react-compiler support HOT 3
- Question: How did you build a JS/TS parser from scratch? HOT 2
- Empty init functions generated for side-effect-free ESM modules HOT 4
- When transform nullish coalescing it transform != null which may lead to wrong result HOT 3
- [css-minifier]Support CSS Anchor Positioning HOT 2
- Generate TypeScript declarations files for TypeScript projects with isolatedDeclarations enabled
- How can I use 'neutral' platform without getting 'The package "x" wasn't found on the file system but is built into node.' error? HOT 2
- DirectAdmin cannot backup application due to hardlink in esbuild HOT 2
- Import attributes should be enabled for `node18` and >= `node20` targets HOT 2
- Code splitting is creating many small unnecessary chunks HOT 1
- Class missing metadata field in certain cases
- Support for the new "${configDir}" template variable coming in TS v5.5.0 HOT 2
- esbuild tried to read "../../.." , in vite , using npm run dev HOT 1
- Destructuring bug in Safari when renamed parameter property is identical to the function name
- Class binding references in static field initializers should be resolved to the decorated class HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esbuild.