Git Product home page Git Product logo

Comments (12)

onnimonni avatar onnimonni commented on June 5, 2024 2

I was also using leighmcculloch/docker-unison as first and when I changed to my version I didn't need to configure anything since I preserved the same configs and it was just plug&play.

My version also allows to use any directory as data mountpoint (other than /data).

I hope it's useful.

EDIT: I somehow wanted to change UNISON_WORKING_DIR -> UNISON_DIR. But besides that it should be okay.

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024 1

implemented and part of the master now

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024

interesting, just to understand it: The effort is to minimize the size of the unison image, right? I am totally willing to doe that.

I will have to look into it myself, the image, what it does and what we need to do. But as far as you say, its a drop in replacement, right?

from docker-sync.

onnimonni avatar onnimonni commented on June 5, 2024

@EugenMayer Sorry I actually changed this one variable in the configs. See the edit.

If this matters I can add backwards compatibility in my image.

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024

I see, that would not matter, just able to change that without any issues.

What i am thinking right now is, if i should actually fork your image and build it myself - jus to ensure we have docker-sync all out of one source. Do not get me wrong, i love contributions, but those images are centric - if they fail, docker-sync fails. They are part of the game and i would love to have this under one roof.

Would you mind me forking your image on dockerhub, and building it and pushing it on eugenmayer/unison - i would, no doubt, leave a comment whom to thank for that alpine image.

I just do not want to step on anybodies toes here!

We also maybe should introduce a setting in the options ( global options ) like rsync_image and unison_image so people could use there owns, if they like. The only fear i have is, that this will flood the issue queue with support requests due to broken images..

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024

one hint leighmcculloch/docker-unison#14 the reason behind that is, it baseimage -> ubuntu. and that will never be as small as the alpine image used by https://github.com/leighmcculloch/docker-unison

from docker-sync.

onnimonni avatar onnimonni commented on June 5, 2024

Yeah no worries use it like you want to 👍!

from docker-sync.

mickaelperrin avatar mickaelperrin commented on June 5, 2024

Just got my macbook back from repair. I start working on this also, mainly to add fsevents on the container side also. If you're not interested by this, I would love an (undocumented / unsupported if needed) option to specify the image to use.

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024

@mickaelperrin i would love to see you progress on this, per request created #35 , should be part of 0.0.12 and in the master today

@onnimonni thank you a lot! i will set this one for the next release, 0.0.12

from docker-sync.

gagarine avatar gagarine commented on June 5, 2024

Very nice! Thanks.

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024

@onnimonni i forked to https://github.com/EugenMayer/docker-unison - i hope thats how you expected things to work out. Give me your blame if i just should change something :)

from docker-sync.

EugenMayer avatar EugenMayer commented on June 5, 2024

@onnimonni i pushed the image and created a branch on https://github.com/EugenMayer/docker-sync/tree/feature/new-unison-image

when you check this branch out, then

bundle install
cd example
thor sync:start

The unison image starts but, the files are synced initially to /app/code, but they are not "resynced" anymore. Any clues?

You should change example/data2/somefile.txt

You can check it this way

docker exec -i -t simpleexample-sync sh
cat /app/code/somefile.txt

Thanks

from docker-sync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.