Git Product home page Git Product logo

Comments (5)

ets avatar ets commented on August 10, 2024

smart_open supports http/s so it can open and read files using the protocol. However - take a look at line 101 here https://github.com/ets/tap-spreadsheets-anywhere/blob/master/tap_spreadsheets_anywhere/file_utils.py
That's the section where http/s isn't yet supported...it's where we collect all the available source files for a config block. For URLs we should probably just return a single target since a file listing isn't practical. Relatively easy PR if you're interested in contributing.

from tap-spreadsheets-anywhere.

andrewcstewart avatar andrewcstewart commented on August 10, 2024

Yep, I can take a stab at it.

Looking at the other list_files_in_* functions, I'm guessing we'd just do a simple passthrough of the URL here, returned as a single element list?

from tap-spreadsheets-anywhere.

ets avatar ets commented on August 10, 2024

Agreed - that seems like the best fit for a URL.

from tap-spreadsheets-anywhere.

andrewcstewart avatar andrewcstewart commented on August 10, 2024

Working on it now. Does the list_files function need to do anything else other than this?

def list_files_in_http_bucket(uri, search_prefix=None):
    entries = [uri]
    LOGGER.info("Found {} files.".format(entries))
    return entries

from tap-spreadsheets-anywhere.

ets avatar ets commented on August 10, 2024

Added support in the latest update.

from tap-spreadsheets-anywhere.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.