Git Product home page Git Product logo

Comments (9)

clabe45 avatar clabe45 commented on May 12, 2024 1

My bad, I thought I pushed it but got sidetracked and never finished it. I'll work on that now!

from etro.

eboujlal avatar eboujlal commented on May 12, 2024 1

Thank you so much, I create an open source video editing webapp based on Vidar, so i am trying to implement all of the features.

from etro.

clabe45 avatar clabe45 commented on May 12, 2024 1

I reverted the commit on my local repo, but there were some issues with the code that I brought back that require some major refactoring. It will probably be several more days until I finish this refactoring.

from etro.

clabe45 avatar clabe45 commented on May 12, 2024 1

I added destX, destY, destWidth and destHeight, which are different from x, y, width and height. The first controls where the image will be rendered onto the layer, and the second controls where the layer will be rendered onto the movie. For image and video layers, width and height default to destWidth and destHeight, but if you set them explicitly to the movie's dimensions they will not. Example:

var movie = new vd.Movie({ canvas });
var layer = new vd.layer.Image({ source: document.querySelector(...), width: movie.width, height: movie.height });
// add rotation effect to layer
// If the image destination bounding box is small enough, it should not be cropped.
// This is because the layer's dimensions fill the entire movie, but the image is only rendered onto part of the layer.

These changes haven't been released yet, so they're not documented. Another unreleased change is that now all arguments are passed to the movies and layers in the options object.

from etro.

clabe45 avatar clabe45 commented on May 12, 2024

Hello! Oh, this is because I removed the imageWidth and imageHeight options in 7ff3d3e. I will re-add them!

from etro.

eboujlal avatar eboujlal commented on May 12, 2024

hello is there any solution ?

from etro.

eboujlal avatar eboujlal commented on May 12, 2024

hello, i need your help in solving this issue.

from etro.

clabe45 avatar clabe45 commented on May 12, 2024

Have you tried it with the master branch? I believe it should be fixed.

i.e.

<script src="https://raw.githubusercontent.com/clabe45/vidar/master/dist/vidar-iife.js"></script>

Please let me know if the bug is still there.

from etro.

eboujlal avatar eboujlal commented on May 12, 2024

hello any update ?

from etro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.