Git Product home page Git Product logo

Comments (10)

jwellbelove avatar jwellbelove commented on September 20, 2024 2

I've corrected the library name and re-tagged 20.28.10

from etl-arduino.

zabuxx avatar zabuxx commented on September 20, 2024

The ETL entry in the Arduino libraries has not been updated since 20.22.0

It is not picked up by the library indexer, with the reason given here

It's an incorrect naming in the library.properties (and library.json):

name=Embedded Template Library - Arduino

should be:

name=Embedded Template Library ETL

Would be great to get access to the latest features of this magnificent library! Thanks!

from etl-arduino.

Mipsters avatar Mipsters commented on September 20, 2024

@zabuxx I fixed this issue in an already merged PR
it's not displayed in Arduino's logs yet because of the issue I describe here
We just need a tag for the fix to apply 🥲

from etl-arduino.

jwellbelove avatar jwellbelove commented on September 20, 2024

I accepted the pull-request, but it seems the sync with the main line ETL reverted it back again.

from etl-arduino.

Mipsters avatar Mipsters commented on September 20, 2024

@jwellbelove you tagged a commit without the pr with the fixes, it's name is still wrong

the tag 20.38.10 currently points to the commit f3c6a31
the name fixes are in the commit 3610df1 (master)

from etl-arduino.

jwellbelove avatar jwellbelove commented on September 20, 2024

I remade the changes on GitHub and committed them directly to master, deleted the old tag, and then recreated the tag for master.

from etl-arduino.

Mipsters avatar Mipsters commented on September 20, 2024

The issue seems to persist, and when I check in GitHub the tag still seems to be on the wrong commit hash

And another thing, I think there may be a redundant "-" in the name in the .properties file
Even if the tag will be on the correct commit, it still won't work because of this

Sorry it takes so long, it seems to be really specific

from etl-arduino.

zabuxx avatar zabuxx commented on September 20, 2024

Hi, from the output of the library indexer it seems this issue persists because in library.properties the line

name=Embedded Template Library ETL

is needed instead of the current

name=Embedded Template Library - ETL

Could you change this for a next release? (I assume this value gets pushed from the main ETLCPP/etl repo)

Thanks

from etl-arduino.

zabuxx avatar zabuxx commented on September 20, 2024

Yes!! ETL 20.38.11 has been added to the Arduino Library !!

Thanks a lot!!

from etl-arduino.

Mipsters avatar Mipsters commented on September 20, 2024

Thank you so much!

from etl-arduino.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.