Comments (5)
Re - Mario's comment on what the protected field is used for:
It's referring to the two different types of transactions described in EIP-155, and instructs the client on how they should sign the transaction.
If set to false, the transaction should be signed without taking into account any Chain ID info.
If set to true, the transaction should be signed using the method described in the EIP.
from execution-spec-tests.
I think it is unclear what this field means. better to print vrs explicitly. or at leas the v signature value.
from execution-spec-tests.
I think it is unclear what this field means. better to print vrs explicitly. or at leas the v signature value.
Exactly this is addressed in #163, it adds signature and sender to (a) all calls to t8n and (b) the fixtures directly, and I think we could remove the protected
field entirely.
from execution-spec-tests.
So we agree that when exporting transaction in the test, just setting v field is enough ( the rest is defined in rlp)
since if someone would want to sign a tx themselvs they will get different rs values anyway it does not make much sense to export rs. but looking at v encoding they can still deduct chainid or determine tx type on old networks
from execution-spec-tests.
Fixed by #187
from execution-spec-tests.
Related Issues (20)
- feat/refactor: extend `EthRPC` framework class and use it in `gentest.py` HOT 1
- Update tests for EIP-2935 for Devnet-1
- Remove workaround to `evmone` not supporting EIP-6110/EIP-7002 introduced in #573
- Fix, clarify, or create alternative tests to incomplete data section tests
- Add `eip6800` (verkle) feature to `configs/feature.yaml` HOT 2
- Prague Devnet-1 Tracker
- evmone t8n produces different test when used with pyspec compared to geth
- feat(consume): add client config files to EEST HOT 1
- feat(fw): finalize transition base class
- feat: MSTORE(bytes) macro HOT 1
- feat(fw): refactor types files for use within EELS HOT 1
- feat: Add `append_sections` to `ethereum_test_tools.eof.v1.Container`
- Missing coverage in EOF container validation tests
- Add EXCHANGE test for EOF
- authorizations not presented in human readable form for type 4 (EIP-7702) txs. HOT 1
- tests for returndata size
- EOF: Expand tests that CALLF into a section without RETF
- EOF: Missing coverage for max sizes HOT 1
- Remaining 7702 Tests for Devnet-3 HOT 1
- feat(consume): refine index file usage for the consume suite
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from execution-spec-tests.