Git Product home page Git Product logo

Comments (13)

djrtwo avatar djrtwo commented on July 18, 2024 2

I'm in favor of changing pylint settings to allow for line lengths up to 100 char instead of default 80. I work on a few python projects (web3.py, pyevm) that do this. Saves me a bit of headache and looks good on most screens.

Thoughts?

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024 1

I'll be focussing on organization and refactors for the time being. Probably one level deeper than you.

@naterush Will continue pushing the experimental dev -- oracles, simulations, etc.

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024 1

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024

yes 100%

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024

hey @zramsay, you going to be just doing review or will you be doing some dev too?

blockchain is our defacto branch until issue 26 is done. Assign yourself to an issue if you are going to pick it up.

Thanks for the issues/review :)

from cbc-casper.

zramsay avatar zramsay commented on July 18, 2024

haha yeah i discovered the "correct" branch. We should use master/develop once its merged. I'll be doing "light" dev work (e.g. tackling linting/useability/documentation, etc)

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024

Cool! Agreed on master/develop.

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024

Check out flake8. does lint+

from cbc-casper.

karlfloersch avatar karlfloersch commented on July 18, 2024

@djrtwo I think it's totally reasonable to push the char limit up. The 80 char limit is too restrictive now that everyone has retina displays

from cbc-casper.

zramsay avatar zramsay commented on July 18, 2024

it's 100 by default already, at least when I run pylint.

from cbc-casper.

djrtwo avatar djrtwo commented on July 18, 2024

from cbc-casper.

zramsay avatar zramsay commented on July 18, 2024

should we also pylint tests ?

from cbc-casper.

naterush avatar naterush commented on July 18, 2024

Closing. Will open new issue about getting CI working again.

from cbc-casper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.