Git Product home page Git Product logo

Comments (3)

asn-d6 avatar asn-d6 commented on May 25, 2024

Not a big fan of writing and supporting a new public method so late in the process. We would likely have to refactor load_trusted_setup_file() as well to avoid code duplication. It's not impossible to do so of course, but something I would avoid.

How does your current code look like? Just to understand what kind of improvement this new function would provide.

from c-kzg-4844.

mattsse avatar mattsse commented on May 25, 2024

We would likely have to refactor load_trusted_setup_file()

yeah that would be ideal.

currently, we're using this approach

https://github.com/paradigmxyz/reth/blob/25558b36c80782a4af614760bb57c34bda7bcdd9/crates/primitives/src/constants/eip4844.rs#L47-L55

from c-kzg-4844.

asn-d6 avatar asn-d6 commented on May 25, 2024

Closing stale tickets. Feel free to reopen if needed.

from c-kzg-4844.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.