smoltcp feature phy-raw_socket requires std about ethercrab HOT 7 CLOSED

Hey @theo-lightworks if you'd like to test the most recent master commit, it should hopefully fix your no_std issue. It's also now tested in CI so hopefully no regressions either!

from ethercrab.

Hey, thanks for opening the issue. Can you describe what the problem is a bit more please? I'm not sure I understand. Are you saying that ethercrab should only enable smoltcp/phy-raw_socket when using its std feature, or something else?

from ethercrab.

Hi, I was interested in testing ethercrab in a no_std environment, but one of the issues with that is that it is not possible to compile ethercrab for no_std as the phy-raw_socket feature of smoltcp is set as a required dependency of ethercrab.

from ethercrab.

Ah I think I see now, thanks! I've opened a fix in #58 which should fix this issue.

from ethercrab.

Hi @jamwaffles It does fix the build, but I have some issues related to async. I tried it with edge-executor, not sure if I am just doing something incorrectly though.

error: future cannot be sent between threads safely
   --> src/lib.rs:30:13
    |
30  |       e.spawn(async {
    |  _____________^
31  | |         setup().await;
32  | |     });
    | |_____^ future created by async block is not `Send`
    |
    = help: within `ethercrab::slave_group::configurator::SlaveGroupRef<'_>`, the trait `Sync` is not implemented for `UnsafeCell<ethercrab::slave_group::configurator::GroupInnerRef<'_>>`
note: future is not `Send` as this value is used across an await
   --> /home/theo/source/ethercrab/src/client.rs:263:73
    |
263 |             offset = unsafe { group.configure_from_eeprom(offset, self).await? };
    |                               -----                                     ^^^^^   - `group` is later dropped here
    |                               |                                         |
    |                               |                                         await occurs here, with `group` maybe used later
    |                               has type `&ethercrab::slave_group::configurator::SlaveGroupRef<'_>` which is not `Send`
note: required by a bound in `Executor::<'a, C, M, S>::spawn`

from ethercrab.

Glad to hear it fixes the build at least :). Do you have a full code example or a repository I could look at somewhere? It's difficult to see what the error might be without more context.

from ethercrab.

I made an example here, I've tried to use libraries that would work on no_std. It works with one executor but not the other https://github.com/flaminggoat/ethercat_no_std

from ethercrab.