Comment can't be deleted about ep_comments_page HOT 13 CLOSED

I just published 0.0.23, give that a go.. A screenshot of your issue would help.

from ep_comments_page.

Unfortunately it appears to still exhibits the same behavior (message sent to server, no server error messages, but the comment isn't removed).

Unfortunately I had to blur out all the text.

The only entry in the server log is [INFO] ueberDB - Flushed 3 values.

Edit:

And the only entry in the browser console is:

{type: "COLLABROOM", data: {type: "ACCEPT_COMMIT", newRev: XXXX}}

(Where XXXX is a new revision number)

from ep_comments_page.

Can you provide steps to replicate the issue on a new pad please?

Initial thoughts are:

a) Because its a full line.
b) Because it's an ordered list.

from ep_comments_page.

John,

Good thinking. I was able to replicate the issue:

1. Start a new pad
2. Create either an unordered or ordered list
3. Highlight part of one line of the list
4. Create a comment
5. Attempt to delete the comment

Let me know if you need additional information to attempt to duplicate the issue.

from ep_comments_page.

Confirmed, will sort tonight hopefully.

from ep_comments_page.

Donations welcome http://etherpad.org

from ep_comments_page.

@JohnMcLear Looks like there is a similar issue when comments are placed on headers created by ep_headers2. Steps to recreate:

1. Start a new pad
2. Create a line and assign a header style
3. Add a comment to a portion of the line
4. Attempt to delete the comment

from ep_comments_page.

If that's teh case its probably an ep_headers2 bug as it uses divs where it should not...

I don't see ep_headers2 though..

from ep_comments_page.

Sorry, not `ep_headers2,headings2``: https://github.com/johnmclear/ep_headings2

from ep_comments_page.

hrm, weird, okay will test.

from ep_comments_page.

Confirmed.. Gah

from ep_comments_page.

Solved :) f838d3e

from ep_comments_page.

Contributions welcome at http://etherpad.org

from ep_comments_page.