Feature suggestion: Display comments as icons on right margin about ep_comments_page HOT 16 CLOSED

Do it in the main branch but put it under a server side setting called "onlyShowCommentIcon" or something :). Its a good suggestion BTW as it keeps the ui clean

from ep_comments_page.

Awesome, thanks!

from ep_comments_page.

Quick question, does this introduce another http request?

from ep_comments_page.

Nope, it just handles what comes on the inner pad (the comment ids), in a
very similar way of what is done with sidebar comments.

On Thursday, June 11, 2015, John McLear [email protected] wrote:

Quick question, does this introduce another http request?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

from ep_comments_page.

I put this live on https://beta.etherpad.org/p/HAKOOKy48b so it gets some testing..

Some thing I noticed..

1. It looks kinda bad when page view isn't on

2. Icons don't look right still?

from ep_comments_page.

Still working on that. I finished my fixes for the icons when PV is off some minutes ago, but had to rebase and now I'm checking if something is broken after the last 30+ commits we had on the last few days. :)

from ep_comments_page.

Yeah sorry about that.. I'm done now =)

from ep_comments_page.

no, no, it was awesome!! Great features, I loved it

from ep_comments_page.

ok, submitted PR #57 now.

from ep_comments_page.

Updated beta.etherpad.org still getting that issue. Maybe it should be forcing page view on too?

from ep_comments_page.

Hum, it looks fine for me when PV is off:

from ep_comments_page.

Note the weird symbol next to the comments icon..

from ep_comments_page.

This is the icon I added to Etherpad code a few days ago. Is beta.etherpad.org using the develop branch?

from ep_comments_page.

blah good point I don't think I pulled the repo, sec..

from ep_comments_page.

There ya go, looking sexy!

Good job!

from ep_comments_page.

:)

from ep_comments_page.