Git Product home page Git Product logo

Comments (6)

AndrewBezold avatar AndrewBezold commented on May 22, 2024

When a contract has a floating solidity version pragma, is it preferred to use the lowest available compatible compiler version or the highest?

from brownie.

iamdefinitelyahuman avatar iamdefinitelyahuman commented on May 22, 2024

I think the highest available version. If the pragma allows it and the user has installed it, to me it seems the logical choice.

from brownie.

AndrewBezold avatar AndrewBezold commented on May 22, 2024

I agree. Would it also be good to have it attempt to install whatever version is needed? I've been looking at the solcx code, and I have ideas about how to change that as well to make this change easier and keep the two conceptually different

from brownie.

iamdefinitelyahuman avatar iamdefinitelyahuman commented on May 22, 2024

If solcx has no compatible version at all, I think it's fine to install the most recent version that fits the pragma.

In a case where there is a compatible version installed locally, but a newer version is available remotely, I don't think it's right to upgrade the local version automatically. Some people (myself included) avoid using the latest version because... well, see solc 0.5.5 ahahaha.

It would be cool to have a notification appear when compiling, saying "there is a newer version of solc available, install via xxx".

from brownie.

iamdefinitelyahuman avatar iamdefinitelyahuman commented on May 22, 2024

re: updates to solcx - i've asked github to change the repo from a fork to a standalone one so that people can open issues. Until that's happened, it only allows conversations via pull requests so we can either discuss it here or you can open a PR there :)

from brownie.

iamdefinitelyahuman avatar iamdefinitelyahuman commented on May 22, 2024

Just merged #82, it includes a method in compiler.py that should make it easy to integrate the auto-versioning with brownie.

from brownie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.