Problem: the concept of an error is used to describe a VM's Need More Information about sputnikvm HOT 5 CLOSED

Totally agreed. We should have another Result type. ExecutionResult<R, N, E>, where R is the return type, N is NMI, and E is Error.

from sputnikvm.

But I'm going to postpone this until the next refactoring is done. That's a little bit more urgent.

from sputnikvm.

@sjmackenzie However, as I think deeper about this. The problem for using three type parameters is that trr! and Rust's try! and question mark syntax is dependent on the Result type. Most of the time, the control flow handling logic for NMI and Error are the same. So I think this is better handled by creating a NMI enum in ExecutionError. But as this doesn't affect any of the structure or logic of the sputnikvm design. This will probably be postponed a little bit till the next refactoring.

from sputnikvm.

Yes the control flow handling is exactly the same, but the semantics are different and now unambiguous - although NMI is a bit obtuse, maybe NeedMoreInfo is better!

from sputnikvm.

Closed via #105

from sputnikvm.