Git Product home page Git Product logo

Comments (5)

sorpaas avatar sorpaas commented on August 16, 2024

This program might be better debugged by using EDB's fire debug. The current return value is:

[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 61]

We'll need to figure out what this program actually do and then check whether this return value is correct or not. Or whether it should actually return an error.

from sputnikvm.

sorpaas avatar sorpaas commented on August 16, 2024

The tests arith and boolean in vmtests.json are of the same problem -- they don't contain "out", while runs successfully.

from sputnikvm.

sjmackenzie avatar sjmackenzie commented on August 16, 2024

out is for chaining vm executions together sub-vm calls, so to say. If the objective is to just test whether the expected output of storage is equal to the actual output of storage then that should be enough information to qualify. Surely there's no need for return_values (aka out) in the situation of arith and boolean tests?

from sputnikvm.

sorpaas avatar sorpaas commented on August 16, 2024

But most of the tests, even if the return value is 0x0, would contain it ("out": "0x"). Tests meant to fail indeed do not contain them.

These three are the exceptions I found that a) execute on the VM successfully, and b) no "out" column.

from sputnikvm.

sorpaas avatar sorpaas commented on August 16, 2024

This problem seems to be fixed after integrating gas cost check.

from sputnikvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.