Error in Node causes a restart of Node-RED about node-red-contrib-denon HOT 10 CLOSED

I had some problems using this node, I uninstalled it and I send directly by TCP on port 23 the string the TV understand as command. It works correctly

from node-red-contrib-denon.

@thmeger Thank you for reporting! Does you denon device 192.168.178.24 is available? Do you able to connect to host with port 23?

from node-red-contrib-denon.

Yes. Controlling the device on that IP and Port 23 works. I do that directly from the Loxone Miniserver. tcp://ip:23/...

from node-red-contrib-denon.

Happens to me as well... Didn't take a look at the logs.
Also I had to install denon-avr and machina - this is not part of the instructions...
Could it be the reason for the restarts? maybe we're using a later library that has different API?

from node-red-contrib-denon.

The title should be Error in Node causes node-red to crash.
Same trace

TypeError: this.connection.getConnection(...).off is not a function

at constructor._onExit (/home/pi/.node-red/node_modules/node-red-contrib-denon/lib/connectionFSM.js:120:57)

Crashes every 60 seconds.

from node-red-contrib-denon.

_onExit: function () { clearTimeout(this.pingTimer); this.connection.getConnection().off('data', receiveData); }

.off is not defined, thats true. You need to change it to .on().
E.g:

_onExit: function () { clearTimeout(this.pingTimer); this.connection.getConnection().on('data', receiveData); }

from node-red-contrib-denon.

@kaui from a contextual standpoint your assertion appears to be nonsense.
onExit should clean up EventEmitters instead of leaking the same reference twice.

from node-red-contrib-denon.

@thomasnordquist you are right, on _onExit routine one have to disable event listeners with off routine.

from node-red-contrib-denon.

@thmeger Current link: https://node-red.slack.com/files/U7SHD5JH4/F9Z9Y2E94/restart_loop.txt is not available without authentication.

from node-red-contrib-denon.

Fixed with: 2c4cf0e

from node-red-contrib-denon.