remove constant declaration from ERC821Psi base classes about erc721psi HOT 3 OPEN

Gas Benchmarking
nidhhoggr/ERC721PsiReports@master...feature/baseContractConstantRemoval

from erc721psi.

@nidhhoggr Not sure if this is true, but I think this can overflow in your implementation.

uint256 end = nextTokenId  + quantity;

from erc721psi.

As mentioned previously, this code was grabbed from the latest commit to ERC721A where the same code is used. I've taken a look at the code and I don't think overflow is possible, here is why.

In the same function the following line is executed before the unchecked block.

_currentIndex += quantity;

At this point _currentIndex and nextTokenId are the same value. If quantity exceeded 2**256 the transaction would automatically revert before the unchecked block is reached. Looking more closely at the code in this commit, we could also get rid of end and just use _currentIndex because they are the same value.

https://github.com/nidhhoggr/ERC721Psi/blob/e0e3ddf43cde2bbec4e30a93caedbdfb7fe66e38/contracts/ERC721Psi.sol#L372

from erc721psi.