Panic when used with complex dependency graph about cargo-udeps HOT 8 CLOSED

Cargo udeps + latest rustc nightly works with noria master. Closing. Thanks for your report.

from cargo-udeps.

Looks like the upstream issue has been fixed in rust-lang/rust#68744. I guess now we just have to wait and see if that makes it possible to run cargo udeps on noria itself :p

from cargo-udeps.

@jonhoo it seems like a problem with save analysis generation, which cargo-udeps uses. If that's the case it would be an upstream bug. Do you have the same issue if you use rls with the repo?

from cargo-udeps.

Seems pretty likely it is an upstream bug, but I'm not sure how to replicate it without cargo-udeps. Running rls in the root of the repository does not produce the error, if that's what you meant?

from cargo-udeps.

cargo udeps -v prints the rustc commands invoked. All we do different from a cargo check run is that we add -Z save-analysis (more or less). I'd file an upstream bug next.

from cargo-udeps.

👍 Filed rust-lang/rust#68621

from cargo-udeps.

Running rls in the root of the repository does not produce the error, if that's what you meant?

IIRC that does nothing but only starts the language service, waiting for commands to be specified in json. both cargo udeps and rls rely on save analysis info from rustc, but it is only being emitted when you actually let rls compile the project. Trying to use vscode+rls on master gives me an error that tokio-tower can't be compiled. Not sure how to debug that.

I can reproduce the issue with cargo udeps on noria's master, but not the linked commit as it gives me:

 Updating git repository `https://github.com/jonhoo/memcached-rs.git`
error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to load source for a dependency on `memcached-rs`

Caused by:
  Unable to update https://github.com/jonhoo/memcached-rs.git?branch=bump-deps#86170708

Caused by:
  revspec '86170708ab2b24c2eb5dbb16d5a3dd61337c18ea' not found; class=Reference (4); code=NotFound (-3)

from cargo-udeps.

Yeah, that commit no longer compiles (the ecosystem moved quickly 😅). master should be fine.

from cargo-udeps.