Git Product home page Git Product logo

Comments (6)

est31 avatar est31 commented on August 16, 2024

cc @qryxip

from cargo-udeps.

est31 avatar est31 commented on August 16, 2024

The issue was that crates-io had a lib name that was different from the package name. crates-io was the package name while crates_io was the lib name. Other packages with dashes have dashes in their lib name too, it's just that crates-io has a custom [lib] section with a name = "crates_io" entry.

from cargo-udeps.

est31 avatar est31 commented on August 16, 2024

In fd3cedf i added a fallback search based on the pkg name instead of the lib name. @qryxip Is the lib name based search actually needed at all?

from cargo-udeps.

matthiaskrgr avatar matthiaskrgr commented on August 16, 2024

I checked with fd3cedf now and there's still a failure with cargo the FIRST time I run cargo-udeps:

Loading save analysis from "/home/matthias/vcs/github/cargo/target/debug/deps/save-analysis/libcrates_io-728b49bbdee2d583.json"
thread 'main' panicked at 'could not find "curl"', /home/matthias/.cargo/git/checkouts/cargo-udeps-a54b3ec58ed788c4/fd3cedf/src/main.rs:402:24
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:47
   3: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:36
   4: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:200
   5: std::panicking::default_hook
             at src/libstd/panicking.rs:214
   6: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:477
   7: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:384
   8: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:339
   9: cargo_udeps::main::{{closure}}
  10: cargo_udeps::main
  11: std::rt::lang_start::{{closure}}
  12: std::rt::lang_start_internal::{{closure}}
             at src/libstd/rt.rs:49
  13: std::panicking::try::do_call
             at src/libstd/panicking.rs:296
  14: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:80
  15: std::panicking::try
             at src/libstd/panicking.rs:275
  16: std::panic::catch_unwind
             at src/libstd/panic.rs:394
  17: std::rt::lang_start_internal
             at src/libstd/rt.rs:48
  18: main
  19: __libc_start_main
  20: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

A second run right after just says All deps seem to have been used. and exits normally. 🤔

from cargo-udeps.

est31 avatar est31 commented on August 16, 2024

After 6213e29 the error message is improved. The problem seems to be that crates-io is not a member of cargo's workspace but is only a path dependency. However, cargo-udeps lints for all path dependencies, workspace members or not. I'll review #18 soon.

from cargo-udeps.

matthiaskrgr avatar matthiaskrgr commented on August 16, 2024

Looks like that fixed it, thanks!

from cargo-udeps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.