NullReferenceException when deserializing expression with constant Guid about serialize.linq HOT 9 CLOSED

Trying to triangulate the problem. Apparently, Guid.NewGuid and Guid.Empty are treated differently.
This expression is deserialized without errors:

Expression<Func<Guid, bool>> exp = g => Guid.NewGuid() != g;

And this one is throwing NRE:

Expression<Func<Guid, bool>> exp = g => Guid.Empty != g;

from serialize.linq.

Another case of deserialization failure:

    var guid = Guid.NewGuid();
    Expression<Func<Company, bool>> exp = c => c.ID == guid;

It looks like whenever a Guid value is provided deserialization fails...

from serialize.linq.

thanks. i will look into it.

from serialize.linq.

Narrowed it down to ConstantExpressionNode. When on deserialization the Value is set then it's a string, no a Guid. For other primitive types (int, bool) the implicit conversion is performed and Value holds the value of correct type...

from serialize.linq.

Guid.NewGuid() is a function call where as Guid.Empty is a static variable.
the question is now, what are you expecting?

g => g == Guid.Empty 

is equivalent to

g => g == new Guid("00000000-0000-0000-0000-000000000000")

from serialize.linq.

I'm still getting NullReferenceException. While trying to simplify reproduction of the problem I've came to Guid.Empty as an example. But with a Guid value the deserializer is still failing. See this failing test:

        [TestMethod]
        public void SerializeDeserializeGuidValue()
        {
            var guidValue = Guid.NewGuid();
            Expression<Func<Guid>> exp = () => guidValue;

            var serializer = new ExpressionSerializer(new JsonSerializer());
            var serialized = serializer.SerializeText(exp);

            serializer.DeserializeText(serialized);
        }

from serialize.linq.

Yet another test:

[TestMethod]
public void SerializeDeserializeGuidValue()
{
    var guidValue = Guid.NewGuid();
    Expression<Func<Guid>> exp = () => guidValue;

    SerializeAndDeserialize(exp, new XmlSerializer());  // PASSES!
    SerializeAndDeserialize(exp, new JsonSerializer()); // FAILS
    SerializeAndDeserialize(exp, new BinarySerializer());   // FAILS
}

public void SerializeAndDeserialize(Expression exp, ISerializer serializer)
{
    var eSerializer = new ExpressionSerializer(serializer);
    eSerializer.DeserializeText(eSerializer.SerializeText(exp));
}

So, only with XmlSerializer expression is deserialized properly.

from serialize.linq.

seems to be a bug in JsonSerializer and BinarySerializer

from serialize.linq.

never mind. i'll fix it.

from serialize.linq.