Comments (3)
I actually think I have solved that one within the code. I would have to test it, but seems (for now ;) ) this change has no unintended effects and fixes this bug and partially even #19
diff -Naur adblock2privoxy-9999.old/adblock2privoxy/src/PatternConverter.hs adblock2privoxy-9999/adblock2privoxy/src/PatternConverter.hs
--- adblock2privoxy-9999.old/adblock2privoxy/src/PatternConverter.hs 2018-07-21 10:18:41.934764472 +0200
+++ adblock2privoxy-9999/adblock2privoxy/src/PatternConverter.hs 2018-07-21 13:37:30.146370607 +0200
@@ -47,7 +47,7 @@
changeFirst (first:cs)
| first == '*' = '.' : '*' : cs
| bindStart == Hard || proto /= "" = first : cs
- | bindStart == Soft = '.' : first : cs
+ | bindStart == Soft = '^' : first : cs
| otherwise = '.' : '*' : first : cs
query' = case query of
from adblock2privoxy.
Turns out there using ^
in front is a bit drastic measure to fix this problem. Yes ||log.
entry would no longer block entries such as ||blog.
, but it also would not block subdomains as test.log.
.
Prime example of it is MajkiIT/polish-ads-filter#8816 where ||tvp.pl/video/vod/reklamy/$domain=tvp.pl
should work for r.tvp.pl
and several similar subdomains, but ^
stops privoxy from doing so.
Maybe adding \.
in front instead would be more appropriate.
from adblock2privoxy.
The first example is correctly translated into a Privoxy action. See https://www.privoxy.org/user-manual/actions-file.html.
The other issues are fixed in #10.
from adblock2privoxy.
Related Issues (20)
- ab2p.common.css causes breakage on some sites HOT 1
- adblock2privoxy segmentation fault HOT 2
- easylist go.*. rule breaks many sites HOT 5
- element hidding whitelists undesired behaviour HOT 1
- empty rules HOT 2
- disregarding information following $ HOT 2
- TODO: remove matched element conversion HOT 1
- adblock2privoxy compilation fail with GHC 8.4.3 HOT 12
- META: work plan for cureent issues HOT 1
- New feature: duplicate detection HOT 1
- unintended escape characters for [ and ] HOT 3
- update filterlist HOT 4
- Dead Download links. HOT 2
- Filters are not taken effect HOT 4
- Ad2p run breaks with "Illegal instruction" HOT 3
- The site https://projects.zubr.me/wiki/adblock2privoxyDownloads does not open HOT 1
- rsync: link_stat "/root/adblock2privoxy*" failed: No such file or directory (2) HOT 5
- Missing client-header tagger 'ab2p-elemhide-check-debug' HOT 2
- Installation: stack command fails with "specified targets matched no packages"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adblock2privoxy.