Git Product home page Git Product logo

Comments (4)

tomwayson avatar tomwayson commented on May 28, 2024

I agree.

My original idea was to have the following folder structure:

  • app: a nice looking app w/ some demos (the gh-pages site) that would have routing, bootstrap, etc.
  • examples: single page bare-bones examples that have no clutter (bootstrap, etc) so developers can clearly see the controller and view code all in one place for each feature
  • dist: the distributable files the people can install into their own apps via bower

The problem is that's a lot of duplication of the code. For each sample, you'd have to write an example page, and then a controller and view for the app.

One idea is to keep the individual pages, but add bootstrap to all of them just to make them look better. The problem w/ that is that the pages won't have the common navigation, etc, or we'd have to add and maintain that in each.

Another idea is to do away w/ the individual pages and replace them w/ routes/controllers/views in the app. I'm fine w/ that, but I think it would be good to group view/controller files in the same folder by route:

app
    simple-map
        SimpleMapCtrl.js
        SimpleMapView.html
    web-map
        WebMapCtrl.js
        WebMapView.html

That way devs aren't bouncing around between app/controllers and app/views to see what's going on.

from angular-esri-map.

alaframboise avatar alaframboise commented on May 28, 2024

Keep in mind that if we use bootstrap we'll need my overrides in bootstrapmap.css to circumvent css conflicts. bootstrapmap.css can be used without bootstrapmap.js.

from angular-esri-map.

tomwayson avatar tomwayson commented on May 28, 2024

FYI - as part of my testing for #7, I updated esri-angular-js as follows:

  • I removed all the directives, and add this repo as a dependency via bower
  • updated the controllers/views to use the directives from this repo and got the app working, which you can see here: http://tomwayson.github.io/esri-angular-js
  • updated README so it says that repo is deprecated and points users here

This shows the directives working both in another repo loaded from bower, and also in a bootstrap app. I forgot to add @alaframboise's css, but it still works - I think b/c the examples are so simple and don't have popups, etc.

Ultimately, I'll probably delete that repo since @jabadia and I have the only forks, but I just wanted to show the directives from this repo working in a bootstrap app since it was already set up.

from angular-esri-map.

tomwayson avatar tomwayson commented on May 28, 2024

So here's my idea about how we could structure (i.e. routes) the gh-pages app:

#/ - jumbotron and a brief intro to the module
#/quick-start - and live map w/ feat. layers and code snippet (like http://esri.github.io/bootstrap-map-js/demo/jquery/getstarted.html)
#/examples - the list of links to and descriptions of the example pages (i.e. the middle section of http://esri.github.io/angular-esri-map/)
#/examples/[example-name] - each individual example
#/about - the "Zen" section from http://esri.github.io/angular-esri-map/

I will do a first pass of that this weekend so we have something a little more attractive to show at next weeks' meeting. Let me know if there's something I missed or if you have other thoughts on the structure.

from angular-esri-map.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.