Git Product home page Git Product logo

Comments (2)

christophlohrmann avatar christophlohrmann commented on September 23, 2024 1

works like a charm

from espresso.

jngrad avatar jngrad commented on September 23, 2024

Thank you for this MWE!

When reloading LB populations, any LB boundary information is overwritten with zeros. There is functionality to regenerate the LB boundary information, but the callback call is missing. Here is the bugfix for 4.2.0 and 4.3-dev:

diff --git a/src/core/grid_based_algorithms/lb.cpp b/src/core/grid_based_algorithms/lb.cpp
index 504f3088f..a6e37cb58 100644
--- a/src/core/grid_based_algorithms/lb.cpp
+++ b/src/core/grid_based_algorithms/lb.cpp
@@ -33,4 +33,5 @@
 #include "communication.hpp"
 #include "errorhandling.hpp"
+#include "event.hpp"
 #include "grid.hpp"
 #include "grid_based_algorithms/lb_boundaries.hpp"
@@ -208,3 +209,4 @@ void lb_initialize_fields(std::vector<LB_FluidNode> &lb_fields,
 #endif // LB_BOUNDARIES
   }
+  on_lbboundary_change();
 }

Could you please confirm that your simulations are fixed with this change? From my side, both the testsuite and your MWE are successful.

This regression was introduced in 4.2.0, back when serialization of object lists was temporarily removed from ESPResSo. The checkpointing test worked around this issue by checking LB boundaries before the LB populations were reloaded. I'll rewrite the test to check LB boundary information both before and after the LB populations are reloaded.

from espresso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.