Git Product home page Git Product logo

Comments (5)

N3xed avatar N3xed commented on May 30, 2024 1

Regarding

(There is also currently a bug where changing the sdkconfig/sdkconfig.defaults does not cause an esp-idf recompilation.)

is there any solution?

This is fixed in master (see commit 468b792) but not in a release yet.

from esp-idf-sys.

ivmarkov avatar ivmarkov commented on May 30, 2024

In the long term though, we should make this configurable (maybe with an approach like I suggested in #72) as the demand for more and more esp-idf components grows.

The approach suggested in #72 might be a bit of an overkill, as it is addressing the problem of how do we compile and generate *-sys bindings for external (out-of-tree) components.

For "in-tree" components, that might be an overkill, especially given that we have like 70% of the solution already:

  • Look at EspIdfComponents and how it is used here, which is the CMake-first build.
  • All that we need is a similar env-var for native build, which is (a) first passed down to CMake and (b) after that is parsed with a very similar code to the above, so that the bindings are generated only for the components which had actually been build. It env var is empty, the code should compile and generate bindings for everything, of course.

From then on, everything is solved already - esp-idf-sys, but also esp-idf-hal and esp-idf-svc are sprinkled with "#ifdefs" using these component strings (they are passed as cfg flags to Rust), so that not just the unsafe wrappers in esp-idf-sys, but also the safe wrappers in esp-idf-svc and esp-idf-hal are conditionally compiled, depending on where the component was enabled or not.

from esp-idf-sys.

ivmarkov avatar ivmarkov commented on May 30, 2024

Just to note that this task became even easier recently, as we no longer have a hard-coded list of esp idf components. I'm instead enumerating the components by doing directory scans instead. This should also make the task for plugging custom components easier.

from esp-idf-sys.

N3xed avatar N3xed commented on May 30, 2024

Yup, I noticed it, just haven't gotten around to implementing it.
Thanks for the notice though.

from esp-idf-sys.

maximeborges avatar maximeborges commented on May 30, 2024

Regarding

(There is also currently a bug where changing the sdkconfig/sdkconfig.defaults does not cause an esp-idf recompilation.)

is there any solution?

from esp-idf-sys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.