Comments (2)
gunterl
commented on August 11, 2024
Hi Erik,
Yes we are aware of this and we will take care of this soon. The print
statements are not the only ones, there are some config parser calls as
well that need to be checked.
Is this a pressing issue? If so I can take care of it next week. Please
assign this issue to me.
Thanks
Gunter
…On Sat, Dec 11, 2021 at 3:02 PM Erik Kluzek ***@***.***> wrote:
I found this running the python reformatter on all of CTSM telling it to
target python-3.7 and it pointed out the following files have python 2 type
print statements so wouldn't work with python-3. Fixing it would be simple
just changing lines
with
print "thing"
to
print( "thing" )
so the fix is straight-forward.
components/cism/source_cism/tests/dome/netCDF.py:
components/cism/source_cism/tests/halfar/halfar_results.py:
components/cism/source_cism/tests/halfar/netCDF.py:
components/cism/source_cism/tests/ismip-hom/netCDF.py:
components/cism/source_cism/tests/ismip-hom/plotISMIP_HOM.py:
components/cism/source_cism/tests/MISMIP3d/mismip3d.code/mismip3dRun.py:
components/cism/source_cism/tests/MISMIP3d/mismip3d.code/mismip3dSetup.py:
components/cism/source_cism/tests/MISMIP3d/mismip3d.code/mismip3dWriteGL.py:
components/cism/source_cism/tests/MISMIP/mismip.code/mismipPlotGL.py:
components/cism/source_cism/tests/MISMIP/mismip.code/mismipRun.py:
components/cism/source_cism/tests/MISMIP/mismip.code/mismipSetup.py:
components/cism/source_cism/tests/MISMIP/mismip.code/mismipWriteGL.py:
components/cism/source_cism/tests/MISOMIP/mismip+/mismip+Run.py:
components/cism/source_cism/tests/MISOMIP/mismip+/mismip+Setup.py:
components/cism/source_cism/tests/MISOMIP/mismip+/mismip+WriteGL.py:
components/cism/source_cism/tests/netCDF.py:
components/cism/source_cism/tests/new/netCDF.py:
components/cism/source_cism/tests/ross/netCDF.py:
components/cism/source_cism/tests/ross/plotRoss.py:
components/cism/source_cism/tests/shelf/netCDF.py:
components/cism/source_cism/tests/slab/netCDF.py:
components/cism/source_cism/tests/slab/plotSlab.py:
components/cism/source_cism/tests/stream/netCDF.py:
components/cism/source_cism/tests/unsupported/exact-isothermal/scripts/create_test.py:
components/cism/source_cism/tests/unsupported/exact-isothermal/scripts/plot_verif.py:
components/cism/source_cism/tests/unsupported/exact-isothermal/scripts/run_verif.py:
components/cism/source_cism/tests/viewNetCDF.py:
components/cism/source_cism/utils/f90_dependency_tool/f90_dependencies.py:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#49>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6QV6CLR6RYYKPPUSVNWS3UQPDAFANCNFSM5J3PAIGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Gunter Leguy, Ph.D
(he/him)
Project Scientist
National Center for Atmospheric Research
cell: (575) 418 1021
desk: (303) 497 1790
from cism.
ekluzek
commented on August 11, 2024
@gunterl OK I assigned it to you as asked. From my perspective this isn't a pressing issue as I know of no problems with this. If any of this python code is run with python3 it will fail, so it could be important for that reason. It looks like most of these are for tests so might not be regularly run. python2 is no longer supported, it's still around on some machines however, so you can sometimes work around that.
Being able to easily catch this does make me want to recommend the use of the black python formatter though. I will add that.
So bottom line -- no not pressing.
from cism.
Related Issues (20)
- If no problem type is specified in .config file, "EISMINT" error occurs HOT 2
- empty 'results' file created during each run HOT 8
- Are changes needed to support a Gregorian (leap year) calendar? HOT 14
- with evolve_ice turned off, beta_internal differs on restart
- Remove SLAP at some point HOT 3
- DIVA is inaccurate when flwa varies strongly vertically HOT 11
- Come up with a way to shorten long lines that reference __FILE__ HOT 3
- Minor issues with SLAP HOT 2
- libglissade IO issues HOT 4
- Encapsulate module-level data in derived types, for parallel module and maybe others HOT 1
- For Antarctica simulations in CESM, SMB can accumulate in the ocean HOT 34
- Glad's is_in_active_grid is slightly inconsistent with logic elsewhere in CISM HOT 2
- SLAP issue with cce (cray compiler) HOT 4
- Rework CISM's time management HOT 1
- cesm build of cism is very slow HOT 14
- Runtime error with nag6.2 compiler on hobart HOT 1
- time dependent forcing applied at incorrect time in timestep HOT 2
- additional testing of centered vs. upwided surface gradient calculations in Glissade dycore HOT 2
- Linux (Ubuntu) build problems. HOT 19
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cism.