Git Product home page Git Product logo

Comments (6)

sommerlukas avatar sommerlukas commented on September 15, 2024

I'm not sure, whether the JSON is actually the problem here. You are requesting the kernel "mytest" in the command-line, but the kernel is name "mytesu" (Note the u instead of t here).
The error message given by TaPaSCo seems to make sense to me, in particular as it even lists the kernel with the name given in the JSON (third item in the list of available kernels).

from tapasco.

sommerlukas avatar sommerlukas commented on September 15, 2024

@forflo: Did you have a chance to test that in the meantime?

from tapasco.

forflo avatar forflo commented on September 15, 2024

Yes. I knew, how to fix it. However, I was slightly disappointed with tapasco's error message not pointing out what you wrote in your comment (from 11 Feb). I would wish for an error message like the json key "name" does not match the directory name. Sorry, if I was being unclear.

Another Question tough:
Is it somewhere documented that the "Id" key of a kernel.json cannot contain the number 0 as id?

Test code:

{
  "Arguments": [
    {
      "Name": "a",
      "Passing": "by reference"
    },
    {
      "Name": "b",
      "Passing": "by reference"
    },
    {
      "Name": "resp__",
      "Passing": "by reference"
    }
  ],
  "Description": "Orka kernel code for kernel 0",
  "Files": [
    "ip_0.c"
  ],
  "Id": 0,
  "Name": "Ip0",
  "TopFunction": "ip",
  "Version": "0.1"
}

which does produce the error
[16:59:21 <main: FileAssetManager$$anon$2> WARN] could not build Kernel from file: '/home/demo/orka/ExplorerIps/ExplorerIp0/kernel.json'

when doing
tapasco -v --coreDir $(pwd)/Cores --kernelDir $(pwd)/Ips/ hls Ip0 -p vcu118

from tapasco.

jahofmann avatar jahofmann commented on September 15, 2024

Currently Tapasco assumes that a slot is empty if the ID is 0, thus, ID 0 is not supported right now. Any particular reason you'd need the ID to be 0?

from tapasco.

sommerlukas avatar sommerlukas commented on September 15, 2024

Yes. I knew, how to fix it. However, I was slightly disappointed with tapasco's error message not pointing out what you wrote in your comment (from 11 Feb). I would wish for an error message like the json key "name" does not match the directory name. Sorry, if I was being unclear.

There might be cases, where the user intents to not match the name of the directory, in which the kernel-description resides, and the kernel name. For example, if one would generate multiple kernels from a single C source-file, the kernel-names won't match the directory name intentionally. Therefore, IMHO it's not a good idea to throw an error/print a warning if the kernel name and the directory name do not match.

from tapasco.

sommerlukas avatar sommerlukas commented on September 15, 2024

For release 2019.10, we will rework the parser for kernel.json-files. The new parser should give better and more informative error messages to allow users to easily identify errors in their files.

from tapasco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.