Douglas Crockford's json2.js, for example, defines a Date.prototype.toJSON function th

Thanks, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-

What about something like this? <div class="highlight highlight-source-js notransl

Relevant: <a class="issue-link js-issue-link" data-error-text="Failed to load titl

Additional json2.js issues: <a class="issue-link

Correct bad Date.prototype.toJSON polyfills from elsewhere about es5-shim HOT 7 CLOSED

es-shims commented on May 22, 2024

Correct bad Date.prototype.toJSON polyfills from elsewhere

from es5-shim.

Comments (7)

petermichaux commented on May 22, 2024

json2.js Date.prototoype.toJSON is also not generic. If json2.js is updated to handle extended dates correctly but not to be generic then the following check would fix things.

if (!Date.prototype.toJSON ||
    // does Date.prototype.toJSON not do extended years properly?
    ((new Date(-62198755200000)).toJSON().indexOf('-000001') === -1) ||
    // is Date.prototype.toJSON non-generic?
    (function() {
        var str = 'abc';
        try {
            return Date.prototype.toJSON.call({toISOString:function(){return str;}}) !== str;
        }
        catch (err) {
            return true;
        }
    }())) {

from es5-shim.

kriskowal commented on May 22, 2024

Thanks, @petermichaux. Good to cross paths again!

from es5-shim.

petermichaux commented on May 22, 2024

I admit the above feature test is ugly.

A workaround that could be documented in the README?...

<script src="json2.js" type="text/javascript"></script>
<script type="text/javascript">
    delete Date.prototype.toJSON
</script>
<script src="es5-shim.js" type="text/javascript"></script>

from es5-shim.

petermichaux commented on May 22, 2024

By the way, Crockford closed my tickets about improving the Date.prototype.toJSON in his json2.js.

from es5-shim.

bryanforbes commented on May 22, 2024

What about something like this?

if (!Date.prototype.toJSON ||
    // does Date.prototype.toJSON not do extended years properly?
    !~((new Date(-62198755200000)).toJSON().indexOf('-000001')) ||
    // is Date.prototype.toJSON non-generic?
    ~(function() {
        try {
            return Date.prototype.toJSON.call({toISOString:function(){return -1;}});
        } catch (err) {
            return true;
        }
    }())) {