Git Product home page Git Product logo

Comments (5)

kriskowal avatar kriskowal commented on May 22, 2024

Thanks. To proceed, we’ll need:

  • someone to confirm that the behavior is not to spec
  • someone to confirm that the behavior does not match existing implementations
  • someone to assess whether existing implementations are consistent among themselves and with the specification
  • a pull request with a jasmine unit test
  • a pull request with the fix

from es5-shim.

michaelficarra avatar michaelficarra commented on May 22, 2024

The proposed fix looks good to me.

from es5-shim.

kriskowal avatar kriskowal commented on May 22, 2024

Thanks @michaelficarra. I’ll take that as a blessing. I’ll accept a pull request with the unit tests and fix.

from es5-shim.

michaelficarra avatar michaelficarra commented on May 22, 2024

I'd still feel more comfortable if we could get somebody else to confirm. Besides the Date mess, the behaviour of (and around) Function.prototype.bind is the hardest part of the ES5 spec. to understand.

from es5-shim.

termi avatar termi commented on May 22, 2024

@kriskowal
Test: termi@c566b93
Fix: termi@f3aeefa
When you are ready I can pull request.
But I am agree with @michaelficarra we need somebody else to confirm.

from es5-shim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.