Git Product home page Git Product logo

Comments (13)

erohtar avatar erohtar commented on May 18, 2024 2

Since there are a lot of options for containers you could build the binary into, and even within a single image line (e.g. nginx) there could be multiple tags to build for and maintain perpetually, I think it would be an immense burden on the creator to maintain what could easily be 20+ images building out of each binary release. And even then people will have edge cases that they want support for.

Thank you @Sierra1011 , that's definitely where I'm at right now. While I understand @christianknell 's pov, right now setting up docker images for all those platforms isn't a priority for me.

from dasherr.

Sierra1011 avatar Sierra1011 commented on May 18, 2024 1

@christianknell Not sure what environment you're working in, but I'm bundling Dasherr and my config files into an nginx container and pushing that to my container registry. Works fine that way.
Alternatively you could use an initContainer to copy your config files into a PV for the Dasherr container to use. Or even handcrank the data initially, or use whatever CI you use to sync files into the volume.

from dasherr.

christianhuth avatar christianhuth commented on May 18, 2024 1

Since there are a lot of options for containers you could build the binary into, and even within a single image line (e.g. nginx) there could be multiple tags to build for and maintain perpetually, I think it would be an immense burden on the creator to maintain what could easily be 20+ images building out of each binary release. And even then people will have edge cases that they want support for.

Thank you @Sierra1011 , that's definitely where I'm at right now. While I understand @christianknell 's pov, right now setting up docker images for all those platforms isn't a priority for me.

and that's of course alright to me. I just wanted to start the discussion as I want to build a Helm Chart for Dasherr. And without fixed Dockerimages I should not do it. Therefore I will wait or find the time to drop you a PR with an automated way of building and releasing the Dockerimage. Thanks so far!

from dasherr.

erohtar avatar erohtar commented on May 18, 2024

Currently no, since it's literally just copying the release files into an existing (trusted) container's www folder. And I already covered the instructions for that in the README - if they're unclear or missing anything, pls let me know and I'll update.

from dasherr.

christianhuth avatar christianhuth commented on May 18, 2024

@erohtar The instructions are clear in my opinion, but without an existing Image there is no way of running the application on Kubernetes.

from dasherr.

erohtar avatar erohtar commented on May 18, 2024

Does installing a webserver container (eg nginx) and copying Dasherr files to that, not work with Kubernetes?

from dasherr.

christianhuth avatar christianhuth commented on May 18, 2024

Not really no. And in general it is far away from the "container and cloud native way" to build containers manually and run these in production environments.

from dasherr.

erohtar avatar erohtar commented on May 18, 2024

I have to agree with you on the latter part there.

Not really no.

Why not?

from dasherr.

christianhuth avatar christianhuth commented on May 18, 2024

Because in Kubernetes you are usually in the context of distributed environments. Therefore you don't know on which node the container will run. You then would need to make the files available on all nodes, where the container might run.

If the files are already included in a pre-build docker image, it would make things way easier and go more into the "best practice" direction.

from dasherr.

erohtar avatar erohtar commented on May 18, 2024

I don't have hands-on experience with Kubernetes myself (yet), so I'm in no position to argue here. I'll keep this open and add a low priority label.

from dasherr.

christianhuth avatar christianhuth commented on May 18, 2024

@Sierra1011: of course that would be possible. But still my point remains: the "real" way of using containers is to do it in an immutable way. Thus releasing fixed versions of the Dockerimage already containing all the files and not copying them over in any way.

from dasherr.

Sierra1011 avatar Sierra1011 commented on May 18, 2024

Since there are a lot of options for containers you could build the binary into, and even within a single image line (e.g. nginx) there could be multiple tags to build for and maintain perpetually, I think it would be an immense burden on the creator to maintain what could easily be 20+ images building out of each binary release. And even then people will have edge cases that they want support for.

Far easier and maintainable to provide the binary and let users drop it into their container of choice, even if that is fractionally more work for them.

I'm sure @erohtar would be open to a PR with an example Dockerfile for the docs?

from dasherr.

Sierra1011 avatar Sierra1011 commented on May 18, 2024

I guess the obvious response would be to offer a single image of nginx:latest and then let users take it as they wish, but if it's not the creator's focus then it's fair to let them just do the binary 🙂

from dasherr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.