Comments (6)
Definitely willing to help out here!
However since the implications of this are a bit bigger then just fixing the bcrypt package build which I did previously I would like to ping @jperkin. He is probably way more impacted then me on anything that is decided here.
It might also be an idea to make a shift between Illumos and Solaris while we are at it since those are slowly drifting apart.
from bcrypt.
@siepkes if this is intended for pkgsrc then we would likely completely ignore this kind of section, it's way too OS-specific, so I wouldn't worry too much about it.
from bcrypt.
I am also a bit surprised by the specificity of this section from the erlang makefiles.
Would be good to at least have it build and work on Solaris/SmartOS and/or illumos.
As I don't have access to these OS's I would be grateful if you could add the correct options and make it work on one or more of those OS's.
I also suspect that the "Linux" section could be the more generic fallback.
When we have fixed this, then I will include it into the 1.2.0
from bcrypt.
uname -s
will report SunOS
on all Solarish OS'es (Solaris, Illumos, etc.). For now it's probably easiest to put all the Solarish OSes under one umbrella.
@mworrell In which repo is the Makefile you reference so I can add the flags, test it and make a PR for it?
from bcrypt.
hi @siepkes, the Makefile is here:
https://github.com/erlangpack/bcrypt/blob/master/c_src/Makefile
This is a new Makefile (derived from erlang-mk) as we are now using rebar3.
As you can see it is missing SunOS completely.
And also Windows... we might want to change the Linux entry into a catch-all.
from bcrypt.
I changed the FreeBSD entry into a catch all.
This might not be enough for Windows, but will be ok for most *nix OS machines.
from bcrypt.
Related Issues (13)
- Error on Ubuntu 18.04.4 with Erlang 11.0.2 OTP23 HOT 4
- Compile problem on Alpine
- Compilation fails - cannot find -lerl_interface HOT 7
- Building on M1 powered Mac always builds a x86 nif.
- Warnings during compilation HOT 2
- Upgrade to newer bcrypt.c
- Hex release HOT 1
- Link failure on OTP 24 HOT 3
- Build instructions
- Reconfigure at runtime HOT 1
- Problem with hex publish in GH Actions
- Fails to compile on OTP 23 due to erl_interface.h HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bcrypt.