Hey thanks for reporting this!

This was introduced recently in #115

I currently am not able to look in to this. Maybe @nettnikl would have time to take a look possible? :)

from restic-automatic-backup-scheduler.

Sure thing! Might be caused by an empty array being used where we want nothing at all? @georgioghazzi could you put in the following right before the restic forget call?

/tmp/t.sh "${extra_args[@]}" 

And execute the following:

echo 'echo "args"; for arg in "$@"; do echo "> $arg"; done; echo "args/"' > /tmp/t.sh
chmod u+x /tmp/t.sh

Then check the diffs with an empty extra_args and one with some dummy arg?

from restic-automatic-backup-scheduler.

Sorry for the late reply.
I've added /tmp/t.sh right before restic forget and i got the same result.

Result Before adding /tmp/t.sh "${extra_args[@]}"

/tmp/t.sh "${extra_args[@]}" added

Result After Adding /tmp/t.sh "${extra_args[@]}"

Results Without "${extra_args[@]}" variable in forget

from restic-automatic-backup-scheduler.

Thanks for your reply! Yeah i just meant to verify the issue - the extra args array is expanded to to " " when empty instead of to nothing. This seems to cause the restic commands to fail in case of positional arguments...
I'll have to think and try a bit more around how to fix.

from restic-automatic-backup-scheduler.

I moved the location of the ${extra_args} to the end of the forget command, but that did not solve the issue.

Thanks for your script btw 👍 🥇 !

from restic-automatic-backup-scheduler.

Okay, so from my tests it seems the only way is to remove the quotes... as with the read command we already took care of input validation etc. (please confirm or explain @erikw if possible) - we maybe could leave them out here?

from restic-automatic-backup-scheduler.

I took the decision to revert #115 with 2873f6a because I don't have time to look at a fix for this right now, and the change as not included in a new release yet.

I'm open to add the functionality of #115 again, if it works out of the box without this bug :)

from restic-automatic-backup-scheduler.