Git Product home page Git Product logo

Comments (3)

mcserep avatar mcserep commented on September 3, 2024

While installation should as fast as possible, we should not support easily broken installations, like not installing the webgui and leaving a previously built, possibly outdated version there.

Instead, an incremental installation of the webgui should be supported. This requires two steps:

  1. Only perform npm install, if the package-lock.json file changed. (For the old GUI, there is only a package.json file.) This is already done.
  2. Do not make a full rebuild of the web GUI, but an incremental build. NextJS supports ISR (Incremental Static Regeneration), though I am not sure how much work it would require to implement it. I would not waste time doing this with the old GUI, unless it is very easy to do.

Alternatively we could use the COMPONENT argument of the install() command in CMake to define multiple installation components. Then it would be possible to install the logger and the parser component and not install the webserver component, if it is not needed in a scenario.

from codecompass.

wbqpk3 avatar wbqpk3 commented on September 3, 2024

Instead, an incremental installation of the webgui should be supported.

I agree, that would indeed be a better option.

Would that be possible to build the webgui during make and check if the webgui source code changed? In that case, make install would just simply copy the built files.

from codecompass.

mcserep avatar mcserep commented on September 3, 2024

The build workflow of Node is not highly compatible with CMake, be it is nice that we have a unified build system for the complete project.

While we can build the frontend during the build stage of CMake, this will raise another performance issue during development. If someone is working on both the GUI and backend Thrift service, he/she would need to rebuild the frontend each time a make command is issued. This is vain, as during development, usually not a statically built version of the frontend is tested, but the development server of NodeJS is utilized.

from codecompass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.