Git Product home page Git Product logo

Comments (4)

ericelliott avatar ericelliott commented on July 26, 2024

The error doesn't get passed to the callback because PBKDF2() throws, upstream from credential. I suppose we could wrap the call in a try/catch and pass the error into the error handler. Would you like to submit a pull request?

from credential.

tommedema avatar tommedema commented on July 26, 2024

Instead of doing a try/catch around PBKDF2, wouldn't it make more sense for pw.hash to do some input validation? e.g. if (typeof(password) !== "string") return cb(new Error("password must be a string"));

from credential.

ericelliott avatar ericelliott commented on July 26, 2024

Yes, I like that better. Please submit a pull request. Please remember to to make the 'p' in password uppercase, as well. :)

from credential.

tommedema avatar tommedema commented on July 26, 2024

pull request sent

from credential.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.