setup.py does not require flask about bind_json_error_handlers HOT 11 OPEN

@eric-s-s hello, I would like to give this issue a try please.

from bind_json_error_handlers.

Travis works because it installs modules listed in requirements.txt.

from bind_json_error_handlers.

as an additional fix, first remove the install of requirements.txt from the .travis.yaml and watch the build fail. then fix

from bind_json_error_handlers.

reference pull request #7

from bind_json_error_handlers.

@ragnarokatz Excellent and welcome!

from bind_json_error_handlers.

as you'll note in the conversation above, first I want to make sure that the travis build will properly fail without the install_requires field. This means first editing the .travis.yaml file so that it doesn't install requirements.txt. Once that build fails, then add the install requires lines and (hopefully) watch it pass on the next build.

from bind_json_error_handlers.

hello @eric-s-s, I have removed both the install_requires field from setup.py, as well as removed the pip install -r requirements.txt line from .travis.yaml. as a result, all checks have failed.

now I will proceed to add back the install_requires field to setup.py file and hopefully all checks will pass.

from bind_json_error_handlers.

nope, still fails:

@eric-s-s
should I add the pip install -r requirements.txt line back in? or do you prefer a different solution?

from bind_json_error_handlers.

definitely a different solution. if you look at the build report, everything loaded fine, and there's some other problem.

from bind_json_error_handlers.

Eric,

Something to try as I think you mentioned it was a breaking change to Flask is to add a constraints.txt to the project to control which version requirements.txt will install if needed.

from bind_json_error_handlers.

as an additional fix, first remove the install of requirements.txt from the .travis.yaml and watch the build fail. then fix

from bind_json_error_handlers.