Failing test cases through maven about erddap HOT 3 CLOSED

I wonder if the license.txt hash issue is related to git behavior on different systems (it can convert line endings on checkout and on commit automatically to make files match what is expected by your OS). This would lead to Linux machines potentially having a different hash for a txt file than a Windows system.

For the NcHelperTests.testUnlimited error, that seems to be a hardcoded path I missed updating previously. I'm fixing that as part of my next update to the maven tests.

For TableTests.testReadOpendapSequenceSpeed, there's no real error there. There probably should not be asserts for time taken because what's good on one machine may be slow on another. Additionally, with the change to using JUnit for testing (instead of the old approach), tests can now be run in parallel. The time based asserts were often set assuming there were no other significant stresses on the system (like other tests).

from erddap.

I believe this has been fixed with the merge of #142

from erddap.

Somehow the MD5 and SHA256 hashes changed on the file or the new hashes were incorrect when updated.
app/target/classes/com/cohort/util/LICENSE.txt

I don't see it being updated in the history log for LICENSE.txt. For HashDigestTests.java, there was a note indicating that the tests were moved around and that the hashing algorithm had changed. See: 7bab64c

Using an interactive development docker container:

root@e03e51ee62d1:/app# md5sum target/classes/com/cohort/util/LICENSE.txt
327fbb2aa6c6297d4fdd5fdf4b14e289  target/classes/com/cohort/util/LICENSE.txt
root@e03e51ee62d1:/app# sha256sum target/classes/com/cohort/util/LICENSE.txt
e376c88953b2d56b00783fed071f1875e8ed94230f4e14eee5bce8bd608de5e6  target/classes/com/cohort/util/LICENSE.txt

I get the same hash for MD5 as @ayushsingh01042003 as seen above.

If you fix the MD5 hash, the SHA256 will fail next. Once the hashes are updated, I get a build success using:

# mvn -f pom.xml package

No other tests fail for me.

from erddap.