Comments (6)
It's a bug, changing
Server/zone/task_client_state.cpp
Line 422 in b1d873d
to
size_t erased = before - m_completed_tasks.size();
should fix it
from server.
It's a bug, changing
Server/zone/task_client_state.cpp
Line 422 in b1d873d
to
size_t erased = before - m_completed_tasks.size();
should fix it
How? size_t is always unsigned. So it deleted no matter the order?
The delete seems correct, but I don't see where the new one is added to the db?
from server.
before
should be greater than m_completed_tasks.size()
after the erase, so currently erased
will underflow and cause m_last_completed_task_loaded
to increment instead of decrement after sign conversions. This prevents the db replace in SaveClientState
because it's now bigger than m_completed_tasks.size
. I assume the task code is just using that variable as a dirty flag for a db update.
edit:
How? size_t is always unsigned. So it deleted no matter the order?
Yes this would delete no matter the order if something was erased, just the db replace doesn't occur to reinsert it with updated time
from server.
You ok with PRing this since you clearly have a better grasp?
from server.
Feel free, it needs confirmation anyway
from server.
I've disabled the rule locally. I don't feel comfortable taking this on.
from server.
Related Issues (20)
- CMake Error at CMakeLists.txt HOT 2
- Ground spawned tradeskill containers don't decay
- NPC DoTs stop doing damage (server side) when corpse is looted.
- Sense Heading does not trigger EVENT_USE_SKILL HOT 3
- Name Validator Doesn't Check Bot Tables
- New Taunt has multiple messages on success. HOT 4
- [Request] /changename support
- [Request] /changepetname support HOT 2
- [Request] /racechange Support
- [Request] /changemercname support
- [Feature] GM Influenced Code Behavior Visibility HOT 1
- Corpse Timers
- 1. Please tell me how to solve the problem that Chinese NPC names display garbled characters on the client!
- 2. The ROF2 client connects to the latest eqemu server. When you right-click on the rof2 game interface for a long time, the game crashes directly! HOT 3
- de-leveling with #setlevel doesn't remove skills you shouldn't have HOT 2
- #resetaa resets Leadership AAs as well but does not return the points or current XP earned to the player HOT 2
- devtools toggle link doesnt bring the devtool window back HOT 1
- Bind Wounds max percentage stuck at 50% for some characters (even with First Aid AA)
- Guide for gating features HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from server.