set_common_compile_options(..) 'forces' C++ language on about micro-cdr HOT 9 CLOSED

I think it is safe to remove enable_language(CXX), can you open a PR?

from micro-cdr.

Perhaps something like:

if("CXX" IN_LIST languages)
  ...
endif()

could be used?

Not sure how to merge that with the rest of the function though. It already seems to check whether CXX is enabled / used for the target arg.

Should those enable_language(..) calls be there?

from micro-cdr.

So far I've been using a fork, but it would be great if this could be resolved here.

Any ideas?

from micro-cdr.

Ping @pablogs9?

from micro-cdr.

The same thing happens in eProsima/Micro-XRCE-DDS-Client btw: here.

That also seems to be a C-only project.

Would you accept a PR there as well?

from micro-cdr.

Yes, we have to check if there is some problem with tests... Please open and let see whats happens with the CI.

from micro-cdr.

Both merged

from micro-cdr.

Thanks

from micro-cdr.

Thanks again.

from micro-cdr.