Comments (25)
Hi @markathomas is it supported in your fork?
what's the main improvements in your fork over the original?
regards
from flutter_twilio_voice.
My fork uses TwilioVoice 5.x and adds features lacking in the original such as putting a call on hold, sending DTMF, explicit answer (for upcoming android support) and returning whether or not one is on call. I also changed the plugin API to return an enum instead of raw strings so the user doesn't have to parse things themselves. Additionally, for my use case, I allow the voice tokens to be supplied to the plugin rather than having the plugin request one with every call; the plugin makes HTTP requests with no authentication so I chose to provide the tokens to the plugin whenever it changes. as I'm using OAuth2 + JWT for security on my API server.
from flutter_twilio_voice.
thanks @markathomas
I git clone
your repo.
When I try to run the example/
I get this:
...
Using `ARCHS` setting to build architectures of target `Pods-Runner`: (``)
Finding Podfile changes
- Flutter
- flutter_twilio_voice
Fetching external sources
-> Fetching podspec for `Flutter` from `.symlinks/flutter/ios`
-> Fetching podspec for `flutter_twilio_voice` from `.symlinks/plugins/flutter_twilio_voice/ios`
Resolving dependencies of `Podfile`
CDN: trunk Relative path: CocoaPods-version.yml exists! Returning local because checking is only perfomed in repo update
[!] CocoaPods could not find compatible versions for pod "TwilioVoice":
In snapshot (Podfile.lock):
TwilioVoice (= 4.1.0, ~> 4.1)
In Podfile:
flutter_twilio_voice (from `.symlinks/plugins/flutter_twilio_voice/ios`) was resolved to 0.0.3, which depends on
TwilioVoice (~> 5.1.1)
Specs satisfying the `TwilioVoice (= 4.1.0, ~> 4.1), TwilioVoice (~> 5.1.1)` dependency were found, but they required a higher minimum deployment target.
do you know how can I fix this?
from flutter_twilio_voice.
i didn't update the example so check the Podfile and Podfile.lock in it for discrepancies. The example is from the main repo and has almost no functionality
from flutter_twilio_voice.
ok thanks!
from flutter_twilio_voice.
@markathomas
Did you ever got app crash at open in the iOS Simulator?
I tried with Xcode 10.3 and 11.3.1 with no luck
App crash with SIGILL
from flutter_twilio_voice.
No, haven't seen that but honestly I tested on a real phone. Do you have a stack trace? Perhaps I can be of assistance
from flutter_twilio_voice.
ok, I will try on a real phone first
I see no stack trace.
thank you
from flutter_twilio_voice.
Did you init the plugin with a valid Twilio VoiceGrant token? You do so like this:
FlutterTwilioVoice.tokens(accessToken: voiceToken, fcmToken: value);
where accessToken
is the Twilio VoiceGrant token and fcmToken
is for Firebase Cloud Messaging (for Android only)
from flutter_twilio_voice.
hmm! you may be right
I generated the jwt token with a python script but I forgot to add it to the code I think
from flutter_twilio_voice.
do you have a small working example I could just git clone
and run?
from flutter_twilio_voice.
no, my project is proprietary
from flutter_twilio_voice.
ok thanks
from flutter_twilio_voice.
@markathomas is your fork still available somewhere? Can't seem to find it
from flutter_twilio_voice.
https://github.com/markathomas/flutter_twilio_voice
from flutter_twilio_voice.
@markathomas thanks :)
from flutter_twilio_voice.
Hello, I have created a new plugin, based on this one with android support. I have also just added null-safety support
https://pub.dev/packages/twilio_voice
from flutter_twilio_voice.
Why a new plugin instead of just creating a PR? This will only confuse users
from flutter_twilio_voice.
Because @eopeter seems away, I don't want to depend on the author's approval each time for improvements
from flutter_twilio_voice.
Hence this repo; perhaps you're unsure how Git works. This repo is independent of @eopeter as he/she is non-responsive as you say. Android support was already added in this repo which you would have known had you simply asked.
from flutter_twilio_voice.
I think you are misunderstanding, this issue is at @eopeter’s main repository, which hasn’t been updated since aug. It doesn’t include android support nor null safety. I am aware your branch does have Android as I contributed myself, but I find it harder for new users to find that the project is still alive and that there’s a working branch (yours) instead of simply searching it on pub.dev.
from flutter_twilio_voice.
If you make a pull request, I can merge it. I am not away. So don't make claims you don't know about.
from flutter_twilio_voice.
I have never received a pull request on this repo even though it's being forked so if you have a contribution to improve it, please make a pull request.
from flutter_twilio_voice.
@eopeter Apologies then, I can submit a PR with Android Support and Null safety. I restructured the plugin calls on mine, I can rollback those changes so there's no breaking change with yours.
from flutter_twilio_voice.
from flutter_twilio_voice.
Related Issues (9)
- No implementation found for method makeCall on channel flutter_twilio_voice HOT 2
- Exception HOT 1
- The plugin homepage is dormmom.com HOT 2
- Is this a complete solution for one-on-one calls? HOT 4
- Missing ability to register with an access token HOT 1
- error on UIApplicationOpenSettingsURLString HOT 2
- Missing plugin exception in android platform HOT 5
- Error No implementation found for method makeCall
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter_twilio_voice.