Comments (1)
Thanks for writing this up @samuelsuarezsanchez!
I like the proposal :)
Here's some feedback:
- consider grouping all the "command hooks" under
hooks
orcommand_hooks
instead of directly under the template name. - an extension would be to support all/other commands other than
apply
anddelete
. - consider renaming the
actions
directory tohooks
orcommand_hooks
. - depending on use case, it may be preferable to always execute the
post_<command>
hooks regardless if the exit status of thepre_<command>
hooks. In this case, a "command status" parameter is passed to the post hooks. For example, the post hooks could be used for some cleanup of the pre hooks that you always want to run. - should post command hooks be executed if the command fails?
To be clear, I'm not suggesting increasing the scope of this proposal, just some things to think about so it can be extended in the future :)
from stack_master.
Related Issues (20)
- Parameters are named with underscores, but stacks are named with dashes HOT 1
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Proposal: erb templating for parameter files HOT 2
- stack_master apply with no changes exits with non-zero HOT 2
- stack_master validate exits with non-zero on valid stack HOT 2
- Empty change list when only stack tags are changing HOT 1
- Add IAM capability 'CAPABILITY_AUTO_EXPAND' to apply.rb HOT 5
- General Inquiry on Directory Structure HOT 6
- Proposal: Add template_dir option to Stacks config HOT 1
- colorize gem is GPL-2 HOT 7
- --enable-termination-protection inquiry HOT 1
- Underscore in region alias causes apply to timeout (slowly)
- Logging-style output doesn't go to stderr
- Unclear error when missing permissions to validate allowed account
- Stack_master not getting installed on windows with Error as Failed to build gem native extension HOT 2
- Status command fails if parameters can't be resolved
- Current OnePassword integration does not support one password `op` cli v2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stack_master.