Git Product home page Git Product logo

Comments (1)

petervandoros avatar petervandoros commented on June 15, 2024

Thanks for writing this up @samuelsuarezsanchez!

I like the proposal :)

Here's some feedback:

  • consider grouping all the "command hooks" under hooks or command_hooks instead of directly under the template name.
  • an extension would be to support all/other commands other than apply and delete.
  • consider renaming the actions directory to hooks or command_hooks.
  • depending on use case, it may be preferable to always execute the post_<command> hooks regardless if the exit status of the pre_<command> hooks. In this case, a "command status" parameter is passed to the post hooks. For example, the post hooks could be used for some cleanup of the pre hooks that you always want to run.
  • should post command hooks be executed if the command fails?

To be clear, I'm not suggesting increasing the scope of this proposal, just some things to think about so it can be extended in the future :)

from stack_master.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.