Git Product home page Git Product logo

Comments (7)

farmaazon avatar farmaazon commented on June 9, 2024

I've assigned p-high because it prevents me from finishing #9790

from enso.

4e6 avatar 4e6 commented on June 9, 2024

If the file is recorded as open by the language server, then the result will return the contents from the in-memory buffer rather than the file on disk.

Maybe it was supposed to be like that, but right now the file/read reads the contents from disk.

from enso.

4e6 avatar 4e6 commented on June 9, 2024

There is another potential issue. The refactor/renameSymbol only returns changes related to the program and does not update the IdMap

from enso.

enso-bot avatar enso-bot commented on June 9, 2024

Dmitry Bushev reports a new STANDUP for today (2024-05-17):

Progress: Updated the file/read method to return the contents of a collaborative buffer if it was opened for the corresponding file. Added tests. Created a PR. It should be finished by 2024-05-22.

Next Day: Next day I will be working on the #9960 task. Continue working on the task

from enso.

4e6 avatar 4e6 commented on June 9, 2024

The fix for the file/read #9994 is merged. The remaining issue is with the IdMap

from enso.

farmaazon avatar farmaazon commented on June 9, 2024

The fix for the file/read #9994 is merged. The remaining issue is with the IdMap

Regarding IdMap; our ydocs server (after a few tweaks) handles the idmap changes if received a code-only update. Thus, the task #9790 is no longer blocked.

For me, this task may be closed - we want to remove idmaps from files anyway.

from enso.

4e6 avatar 4e6 commented on June 9, 2024

Ok, closing this one

from enso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.