Edit button for non-authenticated users, additional check on user. about grav-frontend-edit-button HOT 8 CLOSED

@finanalyst, update: release 1.0.11 solved the refresh for real.

from grav-frontend-edit-button.

Thanks @enovision , I've tested it on two sites and get mixed results (one the button never shows, the other the button stays visible after logout). I can share admin access with you of one site for testing if that helps, please DM me in the Grav Slack room (https://getgrav.org/slack) or email me paul at hibbittsdesign.org

The plugin is really an awesome idea, and I am happy to try to help out where I can!

UPDATE: I think I've got the expected behavior now, perhaps a cache issue on my end. Ah, perhaps it was because I had multiple Grav site Admin's logged in at the same time in one Browser window? Is it a specific check to one site or any Grav Admin? The good news is that things seem to be working!

from grav-frontend-edit-button.

@paulhibbitts, it is checking for admin cookies on the same domain. So if you have more admins open to different domains, they would all have a different admin cookie. It is domain (url) dependent how the cookie is set.
Good news that is seems to work now. Keep me posted if behavior might change unexpectedly.

from grav-frontend-edit-button.

Thanks for the super-useful plugin @enovision ! I seem to have the same issue, the Edit button is visible for all users incl. non-authenticated. Is there a setting I need to adjust? I've set Only visible after login to enabled as well.

from grav-frontend-edit-button.

Same issue here, I had to disable the plugin when not actively working on my website because it will show to everyone, even non logged in users.

from grav-frontend-edit-button.

@finanalyst, you are absolutely right about the editProtect. The issue you address is much more complicated then I can handle here with this plugin. It is about users/groups and content authoring authorizations. It is a deep wish of a lot of Grav CMS fans, so I must put you on hold on this issue.

I have prepared a new version however that solves the button show and not logged in issue. The button now disappears when you log out. Furthermore is the button now optional shown even when not logged in (don't know why, but someone asked me this).

Also is the auto updating of the page tab when losing and regaining focus now optional (also a user request).

You can modify these new options in the plugin settings.

from grav-frontend-edit-button.

Thanks so much @enovision ! I just tweeted about one application of your awesome plugin too🙂https://twitter.com/hibbittsdesign/status/1019988642872246272

UPDATE: Sorry @enovision but there still seems to be an issue with the edit button being visible when no users are logged in. It seemed to work at first, but after several Grav sessions AND logging out the edit button now remains visible (even when logged out and no Grav Admin open). Any ideas?

Happy to test anything that is helpful.

from grav-frontend-edit-button.

@paulhibbitts, I have created release 1.0.12 that surely should make the button disappear. What is does now, it checks if the '-authenticated' cookie is set, if yes it will build the button from the 'twig' template, otherwise it will leave it empty (''). Maybe you could test it if you have the same result as I have, that the button really is gone as expected.

from grav-frontend-edit-button.