Broken Auth Flow with HTTPS about blockbuilder HOT 16 CLOSED

@aurelient awesome thank you - that also worked for me

Sadly, I wasn't quick enough to think to check here last night when I couldn't access my block but then I remembered in the morning primed with coffee. I really appreciate all the work you've done - It's one of my favourite sandboxes!

with errors like this, it might be nice to consider adding a common error screen which captures the error message that @curran shared as well as mentioning places to visit for advice like checking github issues. The home page could also benefit from a section like:

Having issues?

If you encounter any problems, please check our Github issues page and report the issue if it doesn't already exist.

from blockbuilder.

ok redirecting http to https is fixed 🎉 #225

not quite out of the woods on this one though. @enjalot when I click login, I see this error:

AuthorizationError: The redirect_uri MUST match the registered callback URL for this application.
   at Strategy.OAuth2Strategy.authenticate (/home/ubuntu/blockbuilder/node_modules/passport-github/node_modules/passport-oauth2/lib/strategy.js:131:25)
   at attempt (/home/ubuntu/blockbuilder/node_modules/passport/lib/middleware/authenticate.js:348:16)
   at authenticate (/home/ubuntu/blockbuilder/node_modules/passport/lib/middleware/authenticate.js:349:7)
   at Layer.handle [as handle_request] (/home/ubuntu/blockbuilder/node_modules/express/lib/router/layer.js:95:5)
   at next (/home/ubuntu/blockbuilder/node_modules/express/lib/router/route.js:131:13)
   at Route.dispatch (/home/ubuntu/blockbuilder/node_modules/express/lib/router/route.js:112:3)
   at Layer.handle [as handle_request] (/home/ubuntu/blockbuilder/node_modules/express/lib/router/layer.js:95:5)
   at /home/ubuntu/blockbuilder/node_modules/express/lib/router/index.js:277:22
   at Function.process_params (/home/ubuntu/blockbuilder/node_modules/express/lib/router/index.js:330:12)
   at next (/home/ubuntu/blockbuilder/node_modules/express/lib/router/index.js:271:10)

from blockbuilder.

I got the error when I logged out and logged in again.
I'm wondering if we need to provide the full URI for the callbackURL here:

from blockbuilder.

thanks for reporting this @curran

it looks like we need to pass an https redirect_uri to github during the oauth dance for https sessions.

related to #225 - if we redirect http to https, then I think we could just always use the https uri as the redirect_uri

from blockbuilder.

Happened too - can't login.

from blockbuilder.

hoping to have some bandwidth to fix this one soon.

from blockbuilder.

Ok, I've updated the redirect link on the github app to use https. We should probably deploy the redirect to https @micahstubbs

from blockbuilder.

Still getting the Authentication error. Yikes : ((

Congrats, by the way for the app

from blockbuilder.

@eduardosuela did you try loading blockbuilder with https:// instead of http:// ?

from blockbuilder.

@enjalot ack, will deploy the redirect to https this weekend. related issue for that #225

from blockbuilder.

@aurelient it works fine in https

from blockbuilder.

I like the idea of better error handling, and perhaps a FAQ entry too 💡

from blockbuilder.

@enjalot curious, can you check/update the redirect link on the github app one more time?

from blockbuilder.

weird, in an incognito tab, the redirect link seems to work fine. I see the github login page 🤔

but then when I try to login, after I submit my github credentials it fails with the same AuthorizationError: The redirect_uri MUST match the registered callback URL for this application.

from blockbuilder.

This should work now, please confirm

from blockbuilder.

I am now able to log in with github on mobile Chrome. nice work @enjalot!

will close this one as fixed, and re-open if @curran @Fil or others report problems logging in later.

from blockbuilder.