Git Product home page Git Product logo

Comments (15)

usta avatar usta commented on May 28, 2024 2

looks like history repeats itself , first @sooraj-gk then @ampsteric
Ok , from now on please nobody asks for a assign this to me thing , just makes a MR/PR and we will
check if it is ok or not

from endoflife.date.

usta avatar usta commented on May 28, 2024 1

also we can use same svg with rendering it as 32x32 in site-nav part so it will help people to select tools much easier

from endoflife.date.

hugovk avatar hugovk commented on May 28, 2024 1

https://simpleicons.org/ is a good source of CC0 SVG icons, they're also used by https://shields.io/

from endoflife.date.

usta avatar usta commented on May 28, 2024 1

from endoflife.date.

welcome avatar welcome commented on May 28, 2024

Thanks for opening your first issue here! Be sure to follow the issue template!

from endoflife.date.

usta avatar usta commented on May 28, 2024

@captn3m0 @BiNZGi ^^

from endoflife.date.

usta avatar usta commented on May 28, 2024

I have mentioned as svg which will help us to decide its resolution without losing its quality while rendering

from endoflife.date.

captn3m0 avatar captn3m0 commented on May 28, 2024

Simpleicons looks neat. I was also thinking of incorporating icons in the generated visual timeline (small icon at bottom right of the timeline).

Are SVG icons usable as Favicons? Should we use product icons for favicons?

from endoflife.date.

usta avatar usta commented on May 28, 2024

I normally dont want to be "That" guy who always willing to be "grammar nazi"
but @captn3m0 isnt this looks better if we use same structure with other tags ?
I suggest using camelCase system instead of underscores.
I mean using iconSlug instead of icon_slug will be much suitable to keep everything in order

from endoflife.date.

captn3m0 avatar captn3m0 commented on May 28, 2024

Thanks for the note, will take care of it.

from endoflife.date.

usta avatar usta commented on May 28, 2024

I think this one ^^ have forgotten :)

from endoflife.date.

captn3m0 avatar captn3m0 commented on May 28, 2024

If you're working on this, you will need to extend the nav.html file as a include in our repository from the theme we are using: https://github.com/pmarsceill/just-the-docs/blob/master/_includes/nav.html.

Then, add the relevant HTML/CSS to add the icon to the sidebar to display the icon correctly. Make sure the design looks good (and well-aligned) even if we don't have an icon for the product.

See the icon bits in our product page template:

{% if page.iconSlug and page.iconSlug != "NA" %}
<img class=productlogo width=50 height=50 src="https://simpleicons.org/icons/{{page.iconSlug}}.svg" >
{% elsif page.iconSlug != "NA" %}
<img class=productlogo width=50 height=50 src="https://simpleicons.org/icons{{page.permalink}}.svg" >
{% endif %}
to make sure you're parsing the field the same way.

Read through very helpful guide for new contributors during Hacktoberfest as well to understand how to setup the project.

from endoflife.date.

sooraj-gk avatar sooraj-gk commented on May 28, 2024

Sir, can I work on this issue

from endoflife.date.

captn3m0 avatar captn3m0 commented on May 28, 2024

Go ahead, thanks for letting us know 👍🏽

from endoflife.date.

ampsteric avatar ampsteric commented on May 28, 2024

hey! , I would be happy to help.
Please assign me this issue under hacktoberfest.

from endoflife.date.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.