Git Product home page Git Product logo

Comments (5)

GreasyAvocado avatar GreasyAvocado commented on June 20, 2024 1

For anyone who might have the same issue, I've worked around it by migrating the GitHub repo from Branch Protection Rules to Repository Rules.

More details here:
https://github.com/orgs/community/discussions/43460
https://github.blog/changelog/2023-04-17-introducing-repository-rules-public-beta/

from add-and-commit.

EndBug avatar EndBug commented on June 20, 2024 1

That's awesome! Thanks for sharing ❤️

from add-and-commit.

GreasyAvocado avatar GreasyAvocado commented on June 20, 2024

Alternatively, I think it makes more sense to just add a generic way to run GitHub API calls pre\post push, and not something specific for enforce_admins.

WDYT?

from add-and-commit.

EndBug avatar EndBug commented on June 20, 2024

I think it would be better if you handle that outside of the action, by running the call in a step before and after the action's

The action usually takes a couple of seconds to run, so the timing should not cause too many issues unless you're dealing with frequent concurrency (which can, and in your case should, be prevented for this kinds of operations)

You can make sure the rule is always reset to the original status by using if: ${{ always() }} in your step ;)

from add-and-commit.

GreasyAvocado avatar GreasyAvocado commented on June 20, 2024

Got it.
Thanks for the reply!

from add-and-commit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.