Git Product home page Git Product logo

Comments (3)

jordaneremieff avatar jordaneremieff commented on July 23, 2024

I was able to reproduce this issue and the proposed solution works as expected, one thing though, would it perhaps be better to do:

async def send(self, message, send=None, origin=None):
    if message["type"] == "http.response.start":

        message.setdefault("headers", [])
        headers = MutableHeaders(message["headers"])

        # If we only allow specific origins, then we have to mirror back
        # the Origin header in the response.
        if not self.allow_all_origins and origin in self.allow_origins:
            headers["Access-Control-Allow-Origin"] = origin
        headers.update(self.simple_headers)

    await send(message)

instead of omitting the http.response.start check?

from starlette.

tomchristie avatar tomchristie commented on July 23, 2024

Yup that’d be a nice style.

from starlette.

tomchristie avatar tomchristie commented on July 23, 2024

Adding #91, which would have caught this case.

from starlette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.