Git Product home page Git Product logo

Comments (4)

tomchristie avatar tomchristie commented on July 4, 2024

Could be a good one for contributions.

from starlette.

alexbotello avatar alexbotello commented on July 4, 2024

Perhaps we could add a matches method?

def matches(self, scope, origin):
    self.allow_origins = []
    regex = re.compile(self.allow_origin_regex)
    match = regex.match(origin)
    
    if match:
        self.allow_origins.append(origin)
        self.simple_headers["Access-Control-Allow-Origin"] = origin
        return functools.partial(self.simple_response, scope=scope, origin=origin)
    return PlainTextResponse(
        "Disallowed CORS origin", status_code=400,
    )

Then we can call it before preflight_response after the origin check

if origin is not None:
    if self.allow_origin_regex is not None:
        return self.matches(scope=scope, origin=origin)

from starlette.

tomchristie avatar tomchristie commented on July 4, 2024

I guess this line if requested_origin in self.allow_origins: should be:

if self.is_allowed_origin(origin)

Then we can have a is_allowed_origin(origin: str) -> bool method which defaults to origin in self.allowed_origins or self.origin_regex.match(origin) or something like that.

from starlette.

alexbotello avatar alexbotello commented on July 4, 2024

Ah, I see. That's a much better idea. I'll try it out and submit a PR soon.

from starlette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.