Git Product home page Git Product logo

Comments (5)

tomchristie avatar tomchristie commented on July 23, 2024

I think it’s probably better for the library to have handled exceptions be more constrained then simply general purpose responses. That makes it easier to modify the error handling.

from starlette.

imbolc avatar imbolc commented on July 23, 2024

I don't mean using it for exceptions on the library level. It just convenient when you can just "raise" response from some nested coroutine or a middleware rather than passing it all the way back.

from starlette.

tomchristie avatar tomchristie commented on July 23, 2024

Sure, and we have HTTPException for that kind of use-case. It’s just more constrained than having Response itself be an exception class.

from starlette.

imbolc avatar imbolc commented on July 23, 2024

Looking at the code and don't see how can I use a particular response (let's say RedirectResponse) with HTTPException? Let me clarity what I mean by example, with this rising feature we can write:

@app.route('/')
def homepage(request):
    validate_request(request):
    return JSONResponse({'hello': 'world'})

def validate(request):
    raise JSONResponse({...}, status_code=400)

from starlette.

blueyed avatar blueyed commented on July 23, 2024

I guess you could make this work by using a mixin / custom JSONResponse class, and handling it via @app.exception_handler(RaisingJSONResponse), or a middleware.

from starlette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.