Background tasks about starlette HOT 6 CLOSED

Interesting. I look forward to trying this out.

from starlette.

Going along with your example above, it'd be simple to just..

async def __call__(self, receive: Receive, send: Send) -> None:
        await send(
            {
                "type": "http.response.start",
                "status": self.status_code,
                "headers": self.raw_headers,
            }
        )
        await send({"type": "http.response.body", "body": self.body})
        if self.background:
            asyncio.ensure_future(self.background())

Or is that too naive a solution?

from starlette.

@alexbotello That's exactly right, yup.

(To be precise we'd use if self.background is not None)

from starlette.

I played around with this some yesterday. And while this does indeed execute the background task, it also blocks any other incoming requests.
Any ideas how to circumvent that?

from starlette.

it also blocks any other incoming requests.

Are you using time.sleep(...) in testing or some other synchronous code?

from starlette.

...or some other synchronous code?

Ah, yes, I was testing with a synchronous function. In that case a different tack will be needed.
Something like...

loop = asyncio.get_event_loop()
future = await loop.run_in_executor(None, self.background)

This seems to work for synchronous cases. So Response.__call__ could look like...

if self.background is not None:
    task = self.background
    if task.is_coroutine():
        future = asyncio.ensure_future(task())
    else:
        loop = asyncio.get_event_loop()
        future = await loop.run_in_executor(None, task.func)

from starlette.