Comments (3)
Thank you @tomchristie -- just a brief addition. I have actually expressed this wrong, as by "subclass" I was actually thinking of a "subtype", i.e. -- exactly as you said -- that it would be useful if all ASGI apps in Starlette (routes, endpoints etc) shared the same interface. Perhaps that can be formalised in the form of some kind of ABC or mixin or something similar. Thank you for the great work!
from starlette.
I was wondering something similar or maybe when we instantiate Starlette
we can set the router attribute as well, like we are doing with the debug
attribute, but I am.not sure. What do you think guys?
from starlette.
Would it make sense to make Router a subclass of Starlette
Not really, the Router
class is a subset of the features that Starlette
class offers.
If you want to mount a
What we should do tho, is make sure that router and app share the same fundamental API for routing. First pass on that means that stuff like this ought to just work.
app = Router()
@app.route('/')
async def homepage(...):
...
It's possible that we should hide away the lower-level Path
interface (at least at this point), or else find a clean way to expose the same thing in Starlette
, so that the two interfaces match.
Once we've got two properly matching interfaces, then it's clearer.
It's also worth highlighting that you can submount Starlette
instances onto a parent, too. That's what you need to do if you want to have a submounted set of functionality that also handles eg. lifespan, or custom exception handling.
from starlette.
Related Issues (20)
- Drop `python-multipart` dependency
- Warn users if setting too large of a session object
- Typing error for app.add_exception_handler (Argument "handler" to "add_exception_handler" of "Starlette" has incompatible type) HOT 1
- TrustedHostMiddleware raises RuntimeError on sending response to websocket HOT 2
- typing map _RequestData in testclient.py might be missing type bytes HOT 2
- Enable `branch = true` for `coverage.run` HOT 4
- Fetching API docs occasionally fails at starlette framework middleware issue with streaming large responses
- links on the release-notes not found. HOT 1
- Add `Partitioned` cookie attribute HOT 2
- `RuntimeError("No response returned")` in `BaseHTTPMiddleware` HOT 11
- Incompatibility with anyio v3
- TestClient DeprecationWarning with httpx 0.27.0 HOT 5
- Bug: `_TemplateResponse` is still relying on `request` key from `context` which maybe different from `request` argument to `TemplateResponse`. HOT 4
- How to change the value of request body?
- A `RuntimeError: Stream consumed` error is raised when `request.body()` is read in the custom middleware
- CORSMiddleware always add access-control-allow-credentials regardless of Origin
- ValueError when null byte in URL HOT 2
- responses.py - appears UTF incompatible (Line 58 and probably other places)
- Double path unquote inside _TestClientTransport.__init__ method
- [FeatureRequest] Cant configure request.stream() chunk size -- always 128kb per chunk read HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starlette.